Skip to content

Commit

Permalink
Fix heatmap rendering in Chrome and Safari (#13645)
Browse files Browse the repository at this point in the history
* Fix heatmap rendering in Chrome and Safari

Apparently SVG inside flexbox renders slightly different across browsers
where Firefox would stretch to fit the parent while Chrome and safari
wouldn't. Stretch the SVG to the width of the parent for consistent
rendering.

Also did a few minor tweaks on the min-height of the box so it takes up
less space on smaller responsive breakpoints.

Fixes: #13634
Fixes: #13637

* position tweak

Co-authored-by: zeripath <art27@cantab.net>
  • Loading branch information
silverwind and zeripath authored Nov 23, 2020
1 parent f88a2ea commit 24330f7
Showing 1 changed file with 23 additions and 8 deletions.
31 changes: 23 additions & 8 deletions web_src/less/features/heatmap.less
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
align-items: center;
justify-content: center;

> svg {
width: 100%;
}

svg:not(:root) {
overflow: inherit;
padding: 0 !important;
Expand All @@ -16,13 +20,6 @@
fill: currentColor !important;
}

@media @mediaLgAndDown {
&,
& + .divider {
display: none;
}
}

.total-contributions {
font-size: 11px;
position: absolute;
Expand All @@ -31,20 +28,38 @@
}

@media @mediaLgAndDown {
& {
min-height: 105px;
}
.total-contributions {
left: 21px;
}
}

@media (max-width: 1000px) {
& {
min-height: 80px;
}
.total-contributions {
font-size: 10px;
left: 17px;
bottom: -2px;
bottom: -4px;
}
}
}

.user.profile #user-heatmap {
min-height: 135px;
}

@media @mediaLgAndDown {
.user.profile #user-heatmap {
min-height: 115px;
}
}

@media (max-width: 1000px) {
.user.profile #user-heatmap {
min-height: 90px;
}
}

0 comments on commit 24330f7

Please sign in to comment.