fix EasyMDE statusbar margin

wxiaoguang · wxiaoguang · commit 233337da3cf3 · 2022-09-02T14:23:40.000+08:00
diff --git a/templates/repo/issue/comment_tab.tmpl b/templates/repo/issue/comment_tab.tmpl
@@ -14,7 +14,7 @@
 		{{end}}
 	{{end}}
 	{{if .IsAttachmentEnabled}}
-		<div class="field not-under-easymde">
+		<div class="field">
 			{{template "repo/upload" .}}
 		</div>
 	{{end}}
diff --git a/web_src/less/codemirror/base.less b/web_src/less/codemirror/base.less
@@ -1,3 +1,7 @@
+.ui .field:not(:last-child) .EasyMDEContainer .editor-statusbar {
+  margin-bottom: -1em; // when there is a statusbar, the "margin-bottom: 1em" of the "field" is not needed, because the statusbar is likely a blank line
+}
+
 .EasyMDEContainer .CodeMirror {
   color: var(--color-input-text);
   background-color: var(--color-input-background);
diff --git a/web_src/less/features/dropzone.less b/web_src/less/features/dropzone.less
@@ -6,19 +6,12 @@
     padding: 0;
     border-radius: 4px;
     min-height: 0;
-    margin-top: -1em; // we have another `field` above, it's usually an EasyMDE editor with "status bar", so we do not need the space above.
     .dz-message {
       margin: 10px 0;
     }
   }
 }
 
-.ui .field.not-under-easymde {
-  .dropzone {
-    margin-top: 0; // the `field` above isn't an EasyMDE editor
-  }
-}
-
 .dropzone .dz-button {
   color: var(--color-text-light) !important;
 }

Original file line number	Diff line number	Diff line change
`@@ -6,19 +6,12 @@`
`6`	`6`	`padding: 0;`
`7`	`7`	`border-radius: 4px;`
`8`	`8`	`min-height: 0;`
`9`		- margin-top: -1em; // we have another `field` above, it's usually an EasyMDE editor with "status bar", so we do not need the space above.
`10`	`9`	`.dz-message {`
`11`	`10`	`margin: 10px 0;`
`12`	`11`	`}`
`13`	`12`	`}`
`14`	`13`	`}`
`15`	`14`
`16`		`-.ui .field.not-under-easymde {`
`17`		`- .dropzone {`
`18`		- margin-top: 0; // the `field` above isn't an EasyMDE editor
`19`		`- }`
`20`		`-}`
`21`		`-`
`22`	`15`	`.dropzone .dz-button {`
`23`	`16`	`color: var(--color-text-light) !important;`
`24`	`17`	`}`