From 19b017f3986655468d72b383141256f11d58c186 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 28 Jan 2022 13:00:11 -0800 Subject: [PATCH] Use explicit jQuery import, remove unused eslint globals (#18435) - Don't rely on globals (window.$) for jQuery import - Remove eslint globals no longer in use --- .eslintrc | 4 ---- web_src/js/components/ContextPopup.vue | 1 + web_src/js/components/DashboardRepoList.js | 1 + web_src/js/components/RepoBranchTagDropdown.js | 1 + web_src/js/features/admin-common.js | 2 ++ web_src/js/features/admin-emails.js | 2 ++ web_src/js/features/admin-users.js | 2 ++ web_src/js/features/clipboard.js | 2 ++ web_src/js/features/common-global.js | 4 ++-- web_src/js/features/common-issue.js | 1 + web_src/js/features/common-organization.js | 1 + web_src/js/features/comp/ColorPicker.js | 1 + web_src/js/features/comp/EasyMDE.js | 5 +++-- web_src/js/features/comp/ImagePaste.js | 1 + web_src/js/features/comp/LabelEdit.js | 1 + web_src/js/features/comp/MarkupContentPreview.js | 1 + web_src/js/features/comp/ReactionSelector.js | 1 + web_src/js/features/comp/SearchUserBox.js | 1 + web_src/js/features/comp/WebHookEditor.js | 1 + web_src/js/features/contextpopup.js | 2 +- web_src/js/features/heatmap.js | 1 - web_src/js/features/imagediff.js | 2 ++ web_src/js/features/install.js | 2 ++ web_src/js/features/notification.js | 3 ++- web_src/js/features/org-team.js | 2 ++ web_src/js/features/repo-branch.js | 2 ++ web_src/js/features/repo-code.js | 1 + web_src/js/features/repo-commit.js | 2 ++ web_src/js/features/repo-common.js | 2 ++ web_src/js/features/repo-diff.js | 2 ++ web_src/js/features/repo-editor.js | 2 +- web_src/js/features/repo-graph.js | 2 ++ web_src/js/features/repo-home.js | 1 + web_src/js/features/repo-issue-content.js | 2 +- web_src/js/features/repo-issue.js | 1 + web_src/js/features/repo-legacy.js | 1 + web_src/js/features/repo-migrate.js | 2 ++ web_src/js/features/repo-migration.js | 2 ++ web_src/js/features/repo-projects.js | 2 ++ web_src/js/features/repo-release.js | 1 + web_src/js/features/repo-settings.js | 1 + web_src/js/features/repo-template.js | 1 + web_src/js/features/repo-unicode-escape.js | 2 ++ web_src/js/features/repo-wiki.js | 1 + web_src/js/features/sshkey-helper.js | 2 ++ web_src/js/features/stopwatch.js | 3 ++- web_src/js/features/user-auth-webauthn.js | 2 +- web_src/js/features/user-auth.js | 2 ++ web_src/js/features/user-settings.js | 2 ++ web_src/js/index.js | 1 + web_src/js/markup/tasklist.js | 7 ++++--- 51 files changed, 76 insertions(+), 18 deletions(-) diff --git a/.eslintrc b/.eslintrc index b65d3528a87bc..646e66836a42d 100644 --- a/.eslintrc +++ b/.eslintrc @@ -23,9 +23,6 @@ env: globals: __webpack_public_path__: true - CodeMirror: false - Dropzone: false - SimpleMDE: false settings: html/html-extensions: [".tmpl"] @@ -34,7 +31,6 @@ overrides: - files: ["web_src/**/*.js", "web_src/**/*.vue", "templates/**/*.tmpl"] env: browser: true - jquery: true node: false - files: ["templates/**/*.tmpl"] rules: diff --git a/web_src/js/components/ContextPopup.vue b/web_src/js/components/ContextPopup.vue index c002a3d0667ea..0ff141476af1f 100644 --- a/web_src/js/components/ContextPopup.vue +++ b/web_src/js/components/ContextPopup.vue @@ -24,6 +24,7 @@