Use explicit jQuery import, remove unused eslint globals (#18435)

- Don't rely on globals (window.$) for jQuery import
- Remove eslint globals no longer in use

Author: silverwind

.eslintrc

@@ -23,9 +23,6 @@ env:
 
 globals:
   __webpack_public_path__: true
-  CodeMirror: false
-  Dropzone: false
-  SimpleMDE: false
 
 settings:
   html/html-extensions: [".tmpl"]
@@ -34,7 +31,6 @@ overrides:
   - files: ["web_src/**/*.js", "web_src/**/*.vue", "templates/**/*.tmpl"]
     env:
       browser: true
-      jquery: true
       node: false
   - files: ["templates/**/*.tmpl"]
     rules:

web_src/js/components/ContextPopup.vue

@@ -24,6 +24,7 @@
 </template>
 
 <script>
+import $ from 'jquery';
 import {SvgIcon} from '../svg.js';
 
 const {appSubUrl, i18n} = window.config;

web_src/js/components/DashboardRepoList.js

@@ -1,4 +1,5 @@
 import Vue from 'vue';
+import $ from 'jquery';
 import {initVueSvg, vueDelimiters} from './VueComponentLoader.js';
 
 const {appSubUrl, assetUrlPrefix, pageData} = window.config;

web_src/js/components/RepoBranchTagDropdown.js

@@ -1,4 +1,5 @@
 import Vue from 'vue';
+import $ from 'jquery';
 import {vueDelimiters} from './VueComponentLoader.js';
 
 export function initRepoBranchTagDropdown(selector) {

web_src/js/features/admin-common.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 const {csrfToken} = window.config;
 
 export function initAdminCommon() {

web_src/js/features/admin-emails.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 export function initAdminEmails() {
   function linkEmailAction(e) {
     const $this = $(this);

web_src/js/features/admin-users.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 export function initAdminUserListSearchForm() {
   const searchForm = window.config.pageData.adminUserListSearchForm;
   if (!searchForm) return;

web_src/js/features/clipboard.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 const {copy_success, copy_error} = window.config.i18n;
 
 function onSuccess(btn) {

web_src/js/features/common-global.js

@@ -1,9 +1,9 @@
+import $ from 'jquery';
+import 'jquery.are-you-sure';
 import {mqBinarySearch} from '../utils.js';
 import createDropzone from './dropzone.js';
 import {initCompColorPicker} from './comp/ColorPicker.js';
 
-import 'jquery.are-you-sure';
-
 const {csrfToken} = window.config;
 
 export function initGlobalFormDirtyLeaveConfirm() {

web_src/js/features/common-issue.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import {updateIssuesMeta} from './repo-issue.js';
 
 export function initCommonIssue() {