From 16980d13cea3442fcc6a8d327d2622320c26d2fe Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Thu, 9 Jul 2020 23:13:06 +0200 Subject: [PATCH] Default to showing closed Issues/PR list when there are only closed issues/PRs (#12200) If all issues are closed, then set the default to show the closed issues. --- routers/repo/issue.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/routers/repo/issue.go b/routers/repo/issue.go index 181ed59a8c1a8..e3ba5692c4901 100644 --- a/routers/repo/issue.go +++ b/routers/repo/issue.go @@ -139,7 +139,6 @@ func issues(ctx *context.Context, milestoneID int64, isPullOption util.OptionalB return } } - isShowClosed := ctx.Query("state") == "closed" keyword := strings.Trim(ctx.Query("q"), " ") if bytes.Contains([]byte(keyword), []byte{0x00}) { @@ -177,6 +176,13 @@ func issues(ctx *context.Context, milestoneID int64, isPullOption util.OptionalB return } } + + isShowClosed := ctx.Query("state") == "closed" + // if open issues are zero and close don't, use closed as default + if len(ctx.Query("state")) == 0 && issueStats.OpenCount == 0 && issueStats.ClosedCount != 0 { + isShowClosed = true + } + page := ctx.QueryInt("page") if page <= 1 { page = 1