fix old commit nil panic

viletyy · viletyy · commit 0a06837c2c45 · 2023-03-20T18:10:09.000+08:00
diff --git a/routers/api/v1/repo/branch.go b/routers/api/v1/repo/branch.go
@@ -189,6 +189,9 @@ func CreateBranch(ctx *context.APIContext) {
 				ctx.Error(http.StatusInternalServerError, "GetBranchCommit", err)
 				return
 			}
+		} else {
+			ctx.Error(http.StatusNotFound, "", "The old branch does not exist")
+			return
 		}
 	} else {
 		oldCommit, err = ctx.Repo.GitRepo.GetBranchCommit(ctx.Repo.Repository.DefaultBranch)

Original file line number	Diff line number	Diff line change
`@@ -189,6 +189,9 @@ func CreateBranch(ctx *context.APIContext) {`
`189`	`189`	`ctx.Error(http.StatusInternalServerError, "GetBranchCommit", err)`
`190`	`190`	`return`
`191`	`191`	`}`
	`192`	`+ } else {`
	`193`	`+ ctx.Error(http.StatusNotFound, "", "The old branch does not exist")`
	`194`	`+ return`
`192`	`195`	`}`
`193`	`196`	`} else {`
`194`	`197`	`oldCommit, err = ctx.Repo.GitRepo.GetBranchCommit(ctx.Repo.Repository.DefaultBranch)`