GetCommit(): change the comparison for short commit messages

agrn · agrn · commit 4ba06a093cf9 · 2018-04-21T19:34:03.000+02:00
`fatal: ambiguous argument` can be the beginning of two errors in
git. This changes the comparison to something less ambiguous.
diff --git a/repo_commit.go b/repo_commit.go
@@ -125,7 +125,7 @@ func (repo *Repository) GetCommit(commitID string) (*Commit, error) {
 		var err error
 		commitID, err = NewCommand("rev-parse", commitID).RunInDir(repo.Path)
 		if err != nil {
-			if strings.Contains(err.Error(), "fatal: ambiguous argument") {
+			if strings.Contains(err.Error(), "unknown revision or path") {
 				return nil, ErrNotExist{commitID, ""}
 			}
 			return nil, err

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ func (repo Repository) GetCommit(commitID string) (Commit, error) {`
`125`	`125`	`var err error`
`126`	`126`	`commitID, err = NewCommand("rev-parse", commitID).RunInDir(repo.Path)`
`127`	`127`	`if err != nil {`
`128`		`- if strings.Contains(err.Error(), "fatal: ambiguous argument") {`
	`128`	`+ if strings.Contains(err.Error(), "unknown revision or path") {`
`129`	`129`	`return nil, ErrNotExist{commitID, ""}`
`130`	`130`	`}`
`131`	`131`	`return nil, err`