Fix os.Rename paths in darwin-dmg and darwin-pkg packaging

Author: sidevesh

cmd/packaging/darwin-dmg.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"os"
 	"os/exec"
+	"path/filepath"
 )
 
 // DarwinDmgTask packaging for darwin as dmg
@@ -22,8 +23,8 @@ var DarwinDmgTask = &packagingTask{
 		if err != nil {
 			return "", err
 		}
-		appBundleOriginalPath := fmt.Sprintf("dmgdir/%s %s.app", applicationName, version)
-		appBundleFinalPath := fmt.Sprintf("dmgdir/%s.app", applicationName)
+		appBundleOriginalPath := filepath.Join(tmpPath, "dmgdir", fmt.Sprintf("%s %s.app", applicationName, version))
+		appBundleFinalPath := filepath.Join(tmpPath, "dmgdir", fmt.Sprintf("%s.app", applicationName))
 		err = os.Rename(appBundleOriginalPath, appBundleFinalPath)
 		if err != nil {
 			return "", err

cmd/packaging/darwin-pkg.go

@@ -27,8 +27,8 @@ var DarwinPkgTask = &packagingTask{
 			return "", err
 		}
 
-		appBundleOriginalPath := fmt.Sprintf("flat/root/Applications/%s %s.app", applicationName, version)
-		appBundleFinalPath := fmt.Sprintf("flat/root/Applications/%s.app", applicationName)
+		appBundleOriginalPath := filepath.Join(tmpPath, "flat", "root", "Applications", fmt.Sprintf("%s %s.app", applicationName, version))
+		appBundleFinalPath := filepath.Join(tmpPath, "flat", "root", "Applications", fmt.Sprintf("%s.app", applicationName))
 		err = os.Rename(appBundleOriginalPath, appBundleFinalPath)
 		if err != nil {
 			return "", err