From f93efa0fb644f4f541855baae923a63e2bfb350c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lex=20S=C3=A1ez?= Date: Wed, 19 Apr 2023 12:55:26 +0200 Subject: [PATCH] Remove references to freebsd --- pkg/proc/native/proc.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkg/proc/native/proc.go b/pkg/proc/native/proc.go index 71c09fd414..5b8fb81472 100644 --- a/pkg/proc/native/proc.go +++ b/pkg/proc/native/proc.go @@ -246,8 +246,6 @@ func (dbp *nativeProcess) initialize(path string, debugInfoDirs []string) (*proc // We disable asyncpreempt for the following reasons: // - on Windows asyncpreempt is incompatible with debuggers, see: // https://github.com/golang/go/issues/36494 - // - freebsd's backend is generally broken and asyncpreempt makes it even more so, see: - // https://github.com/go-delve/delve/issues/1754 // - on linux/arm64 asyncpreempt can sometimes restart a sequence of // instructions, if the sequence happens to contain a breakpoint it will // look like the breakpoint was hit twice when it was "logically" only @@ -257,7 +255,7 @@ func (dbp *nativeProcess) initialize(path string, debugInfoDirs []string) (*proc // with gdb once AsyncPreempt was enabled. While implementing the port, // few tests failed while it was enabled, but cannot be warrantied that // disabling it fixed the issues. - DisableAsyncPreempt: runtime.GOOS == "windows" || runtime.GOOS == "freebsd" || (runtime.GOOS == "linux" && runtime.GOARCH == "arm64") || (runtime.GOOS == "linux" && runtime.GOARCH == "ppc64le"), + DisableAsyncPreempt: runtime.GOOS == "windows" || (runtime.GOOS == "linux" && runtime.GOARCH == "arm64") || (runtime.GOOS == "linux" && runtime.GOARCH == "ppc64le"), StopReason: stopReason, CanDump: runtime.GOOS == "linux" || (runtime.GOOS == "windows" && runtime.GOARCH == "amd64"),