Skip to content

Commit

Permalink
[net-types] Temporarily disable ip::tests::test_ipv6_display
Browse files Browse the repository at this point in the history
This CL disables the `test_ipv6_display` test because it fails on the
new toolchain. I will fix and re-enable it after the toolchain rolls.

The new toolchain includes rust-lang/rust#112606
which changes the way std formats IP addresses. The test asserts that
net-types formats the same way as std, hence the failure. After the
toolchain rolls, I will change net-types to match std.

Bug: 126927
Change-Id: Ie459a53094b958b752e75e5cf86baa6f55bdade6
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/873649
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Reviewed-by: Joshua Liebow-Feeser <joshlf@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>
  • Loading branch information
Mitchell Kember authored and Rebase bot committed Jun 20, 2023
1 parent 52f6ca7 commit 4196b86
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/connectivity/lib/net-types/src/ip.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3529,6 +3529,9 @@ mod tests {
}

#[test]
// TODO(fxbug.dev/129316): Temporarily disabled for toolchain roll.
// Change to match https://github.com/rust-lang/rust/pull/112606 and re-enable.
#[ignore]
fn test_ipv6_display() {
// Test that `addr` is formatted the same by our `Display` impl as by
// the standard library's `Display` impl. Optionally test that it
Expand Down

0 comments on commit 4196b86

Please sign in to comment.