Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PebbleDB #130

Open
faddat opened this issue Apr 21, 2022 · 0 comments
Open

PebbleDB #130

faddat opened this issue Apr 21, 2022 · 0 comments

Comments

@faddat
Copy link
Contributor

faddat commented Apr 21, 2022

hi,

I've recently been doing a metric ton of work on databases in cosmos, and that is why I haven't popped up my head around here recently.

I think that we're going to find that PebbleDB is glaringly better than others, and that rocks will perform second best to it.

The trouble with rocks is that it forces us to use cgo ffi, and as they say, cgo is not go.

catshark and I have been working on pebbledb support for cosmos here:

https://github.com/osmosis-labs/tm-db/pull/4/files#diff-c80e8d6ab5da73cee445b22b98958c8a9d175f3e0001b29503a6e2983feb179d

Note that I strongly suspect that the current implementation has a bug.

Since I'm aware that Osmosis and many other active chains, like Terra are "trapped" in goleveldb, and that the current overall sentiment is that we should have a single DB so that it is easiest to work with, I would like to suggest that before we jump into a testnet, we make sure that gno can use PebbleDB.

It outperforms all other supported databases, and does not force us to use cgo.

@faddat faddat changed the title databases PebbleDB Apr 21, 2022
@moul moul added this to the 💡Someday/Maybe milestone Oct 20, 2022
@moul moul removed the enhancement label Dec 16, 2022
@moul moul moved this to 🔵 Not Needed for Launch in 🚀 The Launch [DEPRECATED] Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔵 Not Needed for Launch
Development

No branches or pull requests

2 participants