Skip to content

Commit 40fd602

Browse files
committed
Fixed a very rare but critical bug when reducing override rates.
- See main branch commit log for details.
1 parent e321c82 commit 40fd602

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

doc/log/commit_log_v1.0d.txt

+10
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
----------------
2+
Date: 2017-08-01
3+
Author: Sonny Jeon
4+
Subject: Fixed RAMPS control pin conflict
5+
6+
[fix] RAMPS soft-reset control pin interfered with Z-enable. Shifted
7+
all control pins by plus one on the analog pins. RAMPS defines these
8+
pins as belonging to the AUX 2 port, which is assumed to be unused.
9+
10+
111
----------------
212
Date: 2017-07-17
313
Author: Sonny Jeon

grbl/grbl.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
// Grbl versioning system
2525
#define GRBL_VERSION "1.1f"
26-
#define GRBL_VERSION_BUILD "20170801"
26+
#define GRBL_VERSION_BUILD "20170802"
2727

2828
// Define standard libraries used by Grbl.
2929
#include <avr/io.h>

grbl/stepper.c

+3-4
Original file line numberDiff line numberDiff line change
@@ -973,15 +973,14 @@ void st_prep_buffer()
973973
switch (prep.ramp_type) {
974974
case RAMP_DECEL_OVERRIDE:
975975
speed_var = pl_block->acceleration*time_var;
976-
mm_var = time_var*(prep.current_speed - 0.5*speed_var);
977-
mm_remaining -= mm_var;
978-
if ((mm_remaining < prep.accelerate_until) || (mm_var <= 0)) {
976+
if (prep.current_speed-prep.maximum_speed <= speed_var) {
979977
// Cruise or cruise-deceleration types only for deceleration override.
980-
mm_remaining = prep.accelerate_until; // NOTE: 0.0 at EOB
978+
mm_remaining = prep.accelerate_until;
981979
time_var = 2.0*(pl_block->millimeters-mm_remaining)/(prep.current_speed+prep.maximum_speed);
982980
prep.ramp_type = RAMP_CRUISE;
983981
prep.current_speed = prep.maximum_speed;
984982
} else { // Mid-deceleration override ramp.
983+
mm_remaining -= time_var*(prep.current_speed - 0.5*speed_var);
985984
prep.current_speed -= speed_var;
986985
}
987986
break;

0 commit comments

Comments
 (0)