Fix for performance issue in as_dict function #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original function takes 3 seconds to run test_as_dict_perf Updated code has performance inline with flatterdict flatterdict.as_dict code was used for solution
|
@gmr PR is ready for review |
|
Hit this multiple times. I am having to locally fix it. Not ideal. Would be nice to get this fixed in the main repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original function takes 3 seconds to run new test_as_dict_perf() test. Updated code has performance inline with flatterdict as_dict implementation. flatterdict.as_dict code was used to model fix in flatdict.as_dict
tested:
flake8
coverage run
coverage report
coverage xml