Skip to content

Commit f951a0c

Browse files
committed
migrate TaskManager Plugin to the Kibana Platform (elastic#53869)
Migrates the existing TaskManager plugin from Legacy to Kibana Platform. We retain the Legacy API to prevent a breaking change, but under the hood, the legacy plugin is now using the Kibana Platform plugin. Another reason we retain the Legacy plugin to support several features that the Platform team has yet to migrate to Kibana Platform (mapping, SO schema and migrations).
1 parent c9f9b96 commit f951a0c

File tree

95 files changed

+1006
-619
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

95 files changed

+1006
-619
lines changed

src/core/server/mocks.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export { elasticsearchServiceMock } from './elasticsearch/elasticsearch_service.
3737
export { httpServiceMock } from './http/http_service.mock';
3838
export { loggingServiceMock } from './logging/logging_service.mock';
3939
export { savedObjectsClientMock } from './saved_objects/service/saved_objects_client.mock';
40+
export { savedObjectsRepositoryMock } from './saved_objects/service/lib/repository.mock';
4041
export { uiSettingsServiceMock } from './ui_settings/ui_settings_service.mock';
4142
import { uuidServiceMock } from './uuid/uuid_service.mock';
4243

x-pack/legacy/plugins/actions/server/action_type_registry.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
* you may not use this file except in compliance with the Elastic License.
55
*/
66

7-
import { taskManagerMock } from '../../task_manager/server/task_manager.mock';
7+
import { taskManagerMock } from '../../../../plugins/task_manager/server/task_manager.mock';
88
import { ActionTypeRegistry } from './action_type_registry';
99
import { ExecutorType } from './types';
1010
import { ActionExecutor, ExecutorError, TaskRunnerFactory } from './lib';
1111
import { configUtilsMock } from './actions_config.mock';
1212

13-
const mockTaskManager = taskManagerMock.create();
13+
const mockTaskManager = taskManagerMock.setup();
1414
const actionTypeRegistryParams = {
1515
taskManager: mockTaskManager,
1616
taskRunnerFactory: new TaskRunnerFactory(new ActionExecutor()),

x-pack/legacy/plugins/actions/server/action_type_registry.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66

77
import Boom from 'boom';
88
import { i18n } from '@kbn/i18n';
9-
import { TaskManagerSetupContract } from './shim';
10-
import { RunContext } from '../../task_manager/server';
9+
import { RunContext, TaskManagerSetupContract } from '../../../../plugins/task_manager/server';
1110
import { ExecutorError, TaskRunnerFactory } from './lib';
1211
import { ActionType } from './types';
1312
import { ActionsConfigurationUtilities } from './actions_config';
13+
1414
interface ConstructorOptions {
1515
taskManager: TaskManagerSetupContract;
1616
taskRunnerFactory: TaskRunnerFactory;

x-pack/legacy/plugins/actions/server/actions_client.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { ActionTypeRegistry } from './action_type_registry';
1010
import { ActionsClient } from './actions_client';
1111
import { ExecutorType } from './types';
1212
import { ActionExecutor, TaskRunnerFactory } from './lib';
13-
import { taskManagerMock } from '../../task_manager/server/task_manager.mock';
13+
import { taskManagerMock } from '../../../../plugins/task_manager/server/task_manager.mock';
1414
import { configUtilsMock } from './actions_config.mock';
1515
import { getActionsConfigurationUtilities } from './actions_config';
1616

@@ -23,7 +23,7 @@ const defaultKibanaIndex = '.kibana';
2323
const savedObjectsClient = savedObjectsClientMock.create();
2424
const scopedClusterClient = elasticsearchServiceMock.createScopedClusterClient();
2525

26-
const mockTaskManager = taskManagerMock.create();
26+
const mockTaskManager = taskManagerMock.setup();
2727

2828
const actionTypeRegistryParams = {
2929
taskManager: mockTaskManager,

x-pack/legacy/plugins/actions/server/builtin_action_types/index.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import { ActionExecutor, TaskRunnerFactory } from '../lib';
88
import { ActionTypeRegistry } from '../action_type_registry';
9-
import { taskManagerMock } from '../../../task_manager/server/task_manager.mock';
9+
import { taskManagerMock } from '../../../../../plugins/task_manager/server/task_manager.mock';
1010
import { registerBuiltInActionTypes } from './index';
1111
import { Logger } from '../../../../../../src/core/server';
1212
import { loggingServiceMock } from '../../../../../../src/core/server/mocks';
@@ -20,7 +20,7 @@ export function createActionTypeRegistry(): {
2020
} {
2121
const logger = loggingServiceMock.create().get() as jest.Mocked<Logger>;
2222
const actionTypeRegistry = new ActionTypeRegistry({
23-
taskManager: taskManagerMock.create(),
23+
taskManager: taskManagerMock.setup(),
2424
taskRunnerFactory: new TaskRunnerFactory(new ActionExecutor()),
2525
actionsConfigUtils: configUtilsMock,
2626
});

x-pack/legacy/plugins/actions/server/create_execute_function.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
* you may not use this file except in compliance with the Elastic License.
55
*/
66

7-
import { taskManagerMock } from '../../task_manager/server/task_manager.mock';
7+
import { taskManagerMock } from '../../../../plugins/task_manager/server/task_manager.mock';
88
import { createExecuteFunction } from './create_execute_function';
99
import { savedObjectsClientMock } from '../../../../../src/core/server/mocks';
1010

11-
const mockTaskManager = taskManagerMock.create();
11+
const mockTaskManager = taskManagerMock.start();
1212
const savedObjectsClient = savedObjectsClientMock.create();
1313
const getBasePath = jest.fn();
1414

x-pack/legacy/plugins/actions/server/create_execute_function.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
*/
66

77
import { SavedObjectsClientContract } from 'src/core/server';
8-
import { TaskManagerStartContract } from './shim';
8+
import { TaskManagerStartContract } from '../../../../plugins/task_manager/server';
99
import { GetBasePathFunction } from './types';
1010

1111
interface CreateExecuteFunctionOptions {

x-pack/legacy/plugins/actions/server/init.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@
44
* you may not use this file except in compliance with the Elastic License.
55
*/
66

7+
import { Legacy } from 'kibana';
78
import { Plugin } from './plugin';
8-
import { shim, Server } from './shim';
9+
import { shim } from './shim';
910
import { ActionsPlugin } from './types';
1011

11-
export async function init(server: Server) {
12+
export async function init(server: Legacy.Server) {
1213
const { initializerContext, coreSetup, coreStart, pluginsSetup, pluginsStart } = shim(server);
1314

1415
const plugin = new Plugin(initializerContext);

x-pack/legacy/plugins/actions/server/lib/task_runner_factory.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import sinon from 'sinon';
88
import { ExecutorError } from './executor_error';
99
import { ActionExecutor } from './action_executor';
10-
import { ConcreteTaskInstance, TaskStatus } from '../../../task_manager/server';
10+
import { ConcreteTaskInstance, TaskStatus } from '../../../../../plugins/task_manager/server';
1111
import { TaskRunnerFactory } from './task_runner_factory';
1212
import { actionTypeRegistryMock } from '../action_type_registry.mock';
1313
import { actionExecutorMock } from './action_executor.mock';

x-pack/legacy/plugins/actions/server/lib/task_runner_factory.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import { ActionExecutorContract } from './action_executor';
88
import { ExecutorError } from './executor_error';
9-
import { RunContext } from '../../../task_manager/server';
9+
import { RunContext } from '../../../../../plugins/task_manager/server';
1010
import { PluginStartContract as EncryptedSavedObjectsStartContract } from '../../../../../plugins/encrypted_saved_objects/server';
1111
import { ActionTaskParams, GetBasePathFunction, SpaceIdToNamespaceFunction } from '../types';
1212

0 commit comments

Comments
 (0)