Skip to content

Commit ec40593

Browse files
dmlemeshkoelasticmachine
dmlemeshko
and
elasticmachine
authored
[QA] Unskip functional tests (elastic#69760)
* [functional tests] unskip dashboard state * [functional tests] unskip empty dashboard, reference ES issue * [functional tests] unskip data_table_nontime_index * [functional tests] unskip viz builder tests * link existing issue Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1 parent f7acbbe commit ec40593

File tree

5 files changed

+49
-67
lines changed

5 files changed

+49
-67
lines changed

‎test/functional/apps/dashboard/dashboard_state.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -251,8 +251,7 @@ export default function ({ getService, getPageObjects }) {
251251
});
252252
});
253253

254-
// Unskip once https://github.com/elastic/kibana/issues/15736 is fixed.
255-
it.skip('and updates the pie slice legend color', async function () {
254+
it('and updates the pie slice legend color', async function () {
256255
await retry.try(async () => {
257256
const colorExists = await PageObjects.visChart.doesSelectedLegendColorExist('#FFFFFF');
258257
expect(colorExists).to.be(true);
@@ -272,8 +271,7 @@ export default function ({ getService, getPageObjects }) {
272271
});
273272
});
274273

275-
// Unskip once https://github.com/elastic/kibana/issues/15736 is fixed.
276-
it.skip('resets the legend color as well', async function () {
274+
it('resets the legend color as well', async function () {
277275
await retry.try(async () => {
278276
const colorExists = await PageObjects.visChart.doesSelectedLegendColorExist('#57c17b');
279277
expect(colorExists).to.be(true);

‎test/functional/apps/dashboard/empty_dashboard.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,11 @@ export default function ({ getService, getPageObjects }) {
4949
expect(emptyWidgetExists).to.be(true);
5050
});
5151

52-
it.skip('should open add panel when add button is clicked', async () => {
52+
it('should open add panel when add button is clicked', async () => {
5353
await testSubjects.click('dashboardAddPanelButton');
5454
const isAddPanelOpen = await dashboardAddPanel.isAddPanelOpen();
5555
expect(isAddPanelOpen).to.be(true);
56+
await testSubjects.click('euiFlyoutCloseButton');
5657
});
5758

5859
it('should add new visualization from dashboard', async () => {

‎test/functional/apps/discover/_errors.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export default function ({ getService, getPageObjects }) {
3535
await esArchiver.unload('invalid_scripted_field');
3636
});
3737

38-
// https://github.com/elastic/kibana/issues/61366
38+
// ES issue https://github.com/elastic/elasticsearch/issues/54235
3939
describe.skip('invalid scripted field error', () => {
4040
it('is rendered', async () => {
4141
const isFetchErrorVisible = await testSubjects.exists('discoverFetchError');

‎test/functional/apps/visualize/_data_table_nontimeindex.js‎

Lines changed: 41 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export default function ({ getService, getPageObjects }) {
2727
const renderable = getService('renderable');
2828
const PageObjects = getPageObjects(['visualize', 'visEditor', 'header', 'visChart']);
2929

30-
describe.skip('data table with index without time filter', function indexPatternCreation() {
30+
describe('data table with index without time filter', function indexPatternCreation() {
3131
const vizName1 = 'Visualization DataTable without time filter';
3232

3333
before(async function () {
@@ -112,65 +112,49 @@ export default function ({ getService, getPageObjects }) {
112112
expect(data.trim().split('\n')).to.be.eql(['14,004 1,412.6']);
113113
});
114114

115-
it('should show correct data for a data table with date histogram', async () => {
116-
await PageObjects.visualize.navigateToNewVisualization();
117-
await PageObjects.visualize.clickDataTable();
118-
await PageObjects.visualize.clickNewSearch(
119-
PageObjects.visualize.index.LOGSTASH_NON_TIME_BASED
120-
);
121-
await PageObjects.visEditor.clickBucket('Split rows');
122-
await PageObjects.visEditor.selectAggregation('Date Histogram');
123-
await PageObjects.visEditor.selectField('@timestamp');
124-
await PageObjects.visEditor.setInterval('Daily');
125-
await PageObjects.visEditor.clickGo();
126-
const data = await PageObjects.visChart.getTableVisData();
127-
log.debug(data.split('\n'));
128-
expect(data.trim().split('\n')).to.be.eql([
129-
'2015-09-20',
130-
'4,757',
131-
'2015-09-21',
132-
'4,614',
133-
'2015-09-22',
134-
'4,633',
135-
]);
136-
});
115+
// bug https://github.com/elastic/kibana/issues/68977
116+
describe.skip('data table with date histogram', async () => {
117+
before(async () => {
118+
await PageObjects.visualize.navigateToNewVisualization();
119+
await PageObjects.visualize.clickDataTable();
120+
await PageObjects.visualize.clickNewSearch(
121+
PageObjects.visualize.index.LOGSTASH_NON_TIME_BASED
122+
);
123+
await PageObjects.visEditor.clickBucket('Split rows');
124+
await PageObjects.visEditor.selectAggregation('Date Histogram');
125+
await PageObjects.visEditor.selectField('@timestamp');
126+
await PageObjects.visEditor.setInterval('Daily');
127+
await PageObjects.visEditor.clickGo();
128+
});
137129

138-
it('should show correct data for a data table with date histogram', async () => {
139-
await PageObjects.visualize.navigateToNewVisualization();
140-
await PageObjects.visualize.clickDataTable();
141-
await PageObjects.visualize.clickNewSearch(
142-
PageObjects.visualize.index.LOGSTASH_NON_TIME_BASED
143-
);
144-
await PageObjects.visEditor.clickBucket('Split rows');
145-
await PageObjects.visEditor.selectAggregation('Date Histogram');
146-
await PageObjects.visEditor.selectField('@timestamp');
147-
await PageObjects.visEditor.setInterval('Daily');
148-
await PageObjects.visEditor.clickGo();
149-
const data = await PageObjects.visChart.getTableVisData();
150-
expect(data.trim().split('\n')).to.be.eql([
151-
'2015-09-20',
152-
'4,757',
153-
'2015-09-21',
154-
'4,614',
155-
'2015-09-22',
156-
'4,633',
157-
]);
158-
});
130+
it('should show correct data', async () => {
131+
const data = await PageObjects.visChart.getTableVisData();
132+
log.debug(data.split('\n'));
133+
expect(data.trim().split('\n')).to.be.eql([
134+
'2015-09-20',
135+
'4,757',
136+
'2015-09-21',
137+
'4,614',
138+
'2015-09-22',
139+
'4,633',
140+
]);
141+
});
159142

160-
it('should correctly filter for applied time filter on the main timefield', async () => {
161-
await filterBar.addFilter('@timestamp', 'is between', '2015-09-19', '2015-09-21');
162-
await PageObjects.header.waitUntilLoadingHasFinished();
163-
await renderable.waitForRender();
164-
const data = await PageObjects.visChart.getTableVisData();
165-
expect(data.trim().split('\n')).to.be.eql(['2015-09-20', '4,757']);
166-
});
143+
it('should correctly filter for applied time filter on the main timefield', async () => {
144+
await filterBar.addFilter('@timestamp', 'is between', '2015-09-19', '2015-09-21');
145+
await PageObjects.header.waitUntilLoadingHasFinished();
146+
await renderable.waitForRender();
147+
const data = await PageObjects.visChart.getTableVisData();
148+
expect(data.trim().split('\n')).to.be.eql(['2015-09-20', '4,757']);
149+
});
167150

168-
it('should correctly filter for pinned filters', async () => {
169-
await filterBar.toggleFilterPinned('@timestamp');
170-
await PageObjects.header.waitUntilLoadingHasFinished();
171-
await renderable.waitForRender();
172-
const data = await PageObjects.visChart.getTableVisData();
173-
expect(data.trim().split('\n')).to.be.eql(['2015-09-20', '4,757']);
151+
it('should correctly filter for pinned filters', async () => {
152+
await filterBar.toggleFilterPinned('@timestamp');
153+
await PageObjects.header.waitUntilLoadingHasFinished();
154+
await renderable.waitForRender();
155+
const data = await PageObjects.visChart.getTableVisData();
156+
expect(data.trim().split('\n')).to.be.eql(['2015-09-20', '4,757']);
157+
});
174158
});
175159
});
176160
}

‎test/functional/apps/visualize/_tsvb_chart.ts‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
2828
const security = getService('security');
2929
const PageObjects = getPageObjects(['visualize', 'visualBuilder', 'timePicker', 'visChart']);
3030

31-
// FLAKY: https://github.com/elastic/kibana/issues/43150
32-
describe.skip('visual builder', function describeIndexTests() {
31+
describe('visual builder', function describeIndexTests() {
3332
this.tags('includeFirefox');
3433
beforeEach(async () => {
3534
await security.testUser.setRoles(['kibana_admin', 'test_logstash_reader']);
@@ -74,7 +73,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
7473
});
7574
});
7675

77-
// FLAKY: https://github.com/elastic/kibana/issues/46677
7876
describe('gauge', () => {
7977
beforeEach(async () => {
8078
await PageObjects.visualBuilder.resetPage();
@@ -107,7 +105,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
107105
});
108106
});
109107

110-
describe('switch index patterns', () => {
108+
// FLAKY: https://github.com/elastic/kibana/issues/43150
109+
describe.skip('switch index patterns', () => {
111110
beforeEach(async () => {
112111
log.debug('Load kibana_sample_data_flights data');
113112
await esArchiver.loadIfNeeded('kibana_sample_data_flights');

0 commit comments

Comments
 (0)