take into account which features available in the active space

Author: gmmorris

examples/alerting_example/server/plugin.ts

@@ -44,6 +44,7 @@ export class AlertingExamplePlugin implements Plugin<void, void, AlertingExample
         defaultMessage: 'Alerts Example',
       }),
       app: [],
+      alerting: [alwaysFiringAlert.id, peopleInSpaceAlert.id, INDEX_THRESHOLD_ID],
       privileges: {
         all: {
           alerting: {

x-pack/plugins/alerting_builtins/server/feature.ts

@@ -15,6 +15,7 @@ export const BUILT_IN_ALERTS_FEATURE = {
   }),
   icon: 'bell',
   app: [],
+  alerting: [IndexThreshold],
   privileges: {
     all: {
       app: [],

x-pack/plugins/alerts/server/alerts_client_factory.test.ts

@@ -37,6 +37,7 @@ const alertsClientFactoryParams: jest.Mocked<AlertsClientFactoryOpts> = {
   taskManager: taskManagerMock.start(),
   alertTypeRegistry: alertTypeRegistryMock.create(),
   getSpaceId: jest.fn(),
+  getSpace: jest.fn(),
   spaceIdToNamespace: jest.fn(),
   encryptedSavedObjectsClient: encryptedSavedObjectsMock.createClient(),
   actions: actionsMock.createStart(),
@@ -98,6 +99,7 @@ test('creates an alerts client with proper constructor arguments when security i
     alertTypeRegistry: alertsClientFactoryParams.alertTypeRegistry,
     features: alertsClientFactoryParams.features,
     auditLogger: expect.any(AlertsAuthorizationAuditLogger),
+    getSpace: expect.any(Function),
   });
 
   expect(AlertsAuthorizationAuditLogger).toHaveBeenCalledWith(logger);
@@ -146,6 +148,7 @@ test('creates an alerts client with proper constructor arguments', async () => {
     alertTypeRegistry: alertsClientFactoryParams.alertTypeRegistry,
     features: alertsClientFactoryParams.features,
     auditLogger: expect.any(AlertsAuthorizationAuditLogger),
+    getSpace: expect.any(Function),
   });
 
   expect(jest.requireMock('./alerts_client').AlertsClient).toHaveBeenCalledWith({

x-pack/plugins/alerts/server/alerts_client_factory.ts

@@ -15,13 +15,15 @@ import { TaskManagerStartContract } from '../../task_manager/server';
 import { PluginStartContract as FeaturesPluginStart } from '../../features/server';
 import { AlertsAuthorization } from './authorization/alerts_authorization';
 import { AlertsAuthorizationAuditLogger } from './authorization/audit_logger';
+import { Space } from '../../spaces/server';
 
 export interface AlertsClientFactoryOpts {
   logger: Logger;
   taskManager: TaskManagerStartContract;
   alertTypeRegistry: AlertTypeRegistry;
   securityPluginSetup?: SecurityPluginSetup;
   getSpaceId: (request: KibanaRequest) => string | undefined;
+  getSpace: (request: KibanaRequest) => Promise<Space | undefined>;
   spaceIdToNamespace: SpaceIdToNamespaceFunction;
   encryptedSavedObjectsClient: EncryptedSavedObjectsClient;
   actions: ActionsPluginStartContract;
@@ -35,6 +37,7 @@ export class AlertsClientFactory {
   private alertTypeRegistry!: AlertTypeRegistry;
   private securityPluginSetup?: SecurityPluginSetup;
   private getSpaceId!: (request: KibanaRequest) => string | undefined;
+  private getSpace!: (request: KibanaRequest) => Promise<Space | undefined>;
   private spaceIdToNamespace!: SpaceIdToNamespaceFunction;
   private encryptedSavedObjectsClient!: EncryptedSavedObjectsClient;
   private actions!: ActionsPluginStartContract;
@@ -47,6 +50,7 @@ export class AlertsClientFactory {
     this.isInitialized = true;
     this.logger = options.logger;
     this.getSpaceId = options.getSpaceId;
+    this.getSpace = options.getSpace;
     this.taskManager = options.taskManager;
     this.alertTypeRegistry = options.alertTypeRegistry;
     this.securityPluginSetup = options.securityPluginSetup;
@@ -63,6 +67,7 @@ export class AlertsClientFactory {
       authorization: securityPluginSetup?.authz,
       securityLicense: securityPluginSetup?.license,
       request,
+      getSpace: this.getSpace,
       alertTypeRegistry: this.alertTypeRegistry,
       features: features!,
       auditLogger: new AlertsAuthorizationAuditLogger(