libglusterfs: use EVP for SHA-256 checksums - #4717
Open
eli-sterling wants to merge 1 commit into
Open
Conversation
Contributor
|
The changed section wasn't producing warnings on my side, and the |
ThalesBarretto
suggested changes
Sep 5, 2026
ThalesBarretto
left a comment
ThalesBarretto
left a comment
Contributor
There was a problem hiding this comment.
Introduces a "return -1" that is not handled by its callers, and checking it would cause a regression.
Contributor
Author
We'll review soon and if we can't fix it quickly, we'll withdraw the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the issue-named, current-devel replacement for PR #4709.
Updates: #2916
Validation:
libglusterfs.laandcommon-utils.lobuilt successfully with-j 6.The original PR remains open until this replacement is verified.