Provide a dotnet global tool version of ilrepack #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Automatically version from github.ref * Build and test on windows, only sanity check run on others * Build using desktop MSBuild: This is what appveyor does. * Pack separately just the tools project.
This command also helps check the tool is installed properly and can run, returning a success status code, without having to repack anything actually.
Avoids having to skip it for the auto-generated .vs when you open a single project from the integration tests folder, for example
In order to test that the basics of the dotnet-ilrepack tool are working in all supported OSes, we pick a clean and common scenario that doesn't require any particular workload, and which builds fast, as a simple end-to-end sanity check for the global tool itself. Note that the extensive tests already run on the code from existing tests is a prerequisite already for the test tool job.
This makes merging this PR to upstream can be done even if the GH workflows aren't used for publishing.
kzu
changed the title
kzu
added a commit
to devlooped/SponsorLink
that referenced
this pull request
Jul 8, 2024
This simplifies consumption and avoids having to create custom CI build steps to install the right tool. If the PR to include this global tool in the main ILRepack distribution is merged (see gluck/il-repack#364), we can remove the --add-source and --prerelease switches.
|
Thanks! I'll take a look soon. This would fix #289 |
|
Any ETA? |
|
I'm very busy these days but I'll try and take a look within a week or two. |
KirillOsenkov
approved these changes
Jul 26, 2024
|
I uploaded https://www.nuget.org/packages/dotnet-ilrepack/1.0.0 manually for now, could you please try it out? |
|
Not the OP, but I can confirm that the tool is working fine. Thanks! |
|
@KirillOsenkov it should be the secret in settings, not in env... not sure both map equally 🤔 . |
kzu
added a commit
to devlooped/SponsorLink
that referenced
this pull request
Aug 2, 2024
kzu
added a commit
to devlooped/SponsorLink
that referenced
this pull request
Aug 2, 2024
kzu
added a commit
to devlooped/SponsorLink
that referenced
this pull request
Aug 2, 2024
|
Published package works like a charm. If some day you the nuget secret in the repo, future publishing is just a matter of creating a release (for both packages) 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dotnet global tool of ilrepack would be much easier to install and use in a cross-platform manner.
This PR provides:
The workflows automatically detect and use two repository/org secrets:
SLEET_CONNECTION: an optional Sleet connection string to provide a CI feed for dogfoodingNUGET_API_KEYto push both the original package and the dotnet-tool to nuget.org when a release (or prerelease) is created.An example run of the build workflow can be seen in action at https://github.com/kzu/il-repack/actions/runs/9846710011.
And the published CI package for the global tool can be installed with:
And checked with:
ilrepack --version.