README precompile example path separator issue

[GravlLift]

There's something strange going on with path separators on Windows in the precompile example in the readme. The path.dirname call correctly reads out the base directory as, for example, C:\\folder\\subFolder, and the path is successfully combined with the item in the url call, generating something like C:\\folder\\subFolder/./assets/image/png.

If I add a dummy plugin to esbuild, I can see that an onResolve call will then be attempted to be made to C:foldersubFolder/./assets/image/png by this plugin.

I was able to resolve the issue by either double escaping the windows path seperator...

return source.replace(
  /(url\(['"]?)(\.\.?\/)([^'")]+['"]?\))/g,
  `$1${baseDir.replace(/\\/g, '\\\\')}/$2$3`
);

... or by using / instead:

return source.replace(
  /(url\(['"]?)(\.\.?\/)([^'")]+['"]?\))/g,
  `$1${baseDir.replace(/\\/g, '/')}/$2$3`
);

I'm not exactly sure what's going on there, but at least its workaroundable.

[glromeo]

I close this hoping the documentation is clear enough now