Skip to content

Commit 3dfa654

Browse files
committed
[doc] clarify effective feerate
1 parent 0603756 commit 3dfa654

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/rpc/mempool.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1085,7 +1085,8 @@ static RPCHelpMan submitpackage()
10851085
{RPCResult::Type::NUM, "vsize", /*optional=*/true, "Sigops-adjusted virtual transaction size."},
10861086
{RPCResult::Type::OBJ, "fees", /*optional=*/true, "Transaction fees", {
10871087
{RPCResult::Type::STR_AMOUNT, "base", "transaction fee in " + CURRENCY_UNIT},
1088-
{RPCResult::Type::STR_AMOUNT, "effective-feerate", /*optional=*/true, "if the transaction was not already in the mempool, the effective feerate in " + CURRENCY_UNIT + " per KvB. For example, the package feerate and/or feerate with modified fees from prioritisetransaction."},
1088+
{RPCResult::Type::STR_AMOUNT, "effective-feerate", /*optional=*/true, "if the transaction was not already in the mempool, the effective feerate in " + CURRENCY_UNIT +
1089+
" per KvB. For example, the package feerate and/or feerate with modified fees from prioritisetransaction. Not the same thing as chunk feerate."},
10891090
{RPCResult::Type::ARR, "effective-includes", /*optional=*/true, "if effective-feerate is provided, the wtxids of the transactions whose fees and vsizes are included in effective-feerate.",
10901091
{{RPCResult::Type::STR_HEX, "", "transaction wtxid in hex"},
10911092
}},
@@ -1235,6 +1236,8 @@ static RPCHelpMan submitpackage()
12351236
UniValue fees(UniValue::VOBJ);
12361237
fees.pushKV("base", ValueFromAmount(it->second.m_base_fees.value()));
12371238
if (tx_result.m_result_type == MempoolAcceptResult::ResultType::VALID) {
1239+
// Effective feerate (the feerate used at the time of validation) is not the same thing as chunk
1240+
// feerate (which is determined after adding the transaction to mempool).
12381241
// Effective feerate is not provided for MEMPOOL_ENTRY transactions even
12391242
// though modified fees is known, because it is unknown whether package
12401243
// feerate was used when it was originally submitted.

0 commit comments

Comments
 (0)