JOSS review: Projection specification in glottomap

[skalyan91]

The 'pacific' value of the projection argument of glottomap() does not work; I get the following error:

Error in `.data[["black"]]`:
! Column `black` not found in `.data`.
Run `rlang::last_error()` to see where the error occurred.

In addition, the documentation says that projections other than equal-area and Pacific-centred equal-area may be specified by their “EPSG code”. This is inaccurate: in fact, the function requires the EPSG description, not the EPSG code. E.g. for the “World Mollweide” projection, the EPSG code is 54009, but the description is +proj=moll +lon_0=0 +x_0=0 +y_0=0 +ellps=WGS84 +datum=WGS84 +units=m no_defs; only the latter (as a string) is a valid projection argument of the glottomap() function.

[SietzeN]

Hi @skalyan91 !

I've fixed the error with the 'pacific' projection.

The function does accept an EPSG code, but this should be the full code, not only the number. I've added an example in the 'projection' parameter description in the glottomap function.

For example: glottomap(projection = "ESRI:54009") plots all languages worldwide in the World Mollweide projection.

I will close this issue with the next push.

Thanks!
Sietze