-
Notifications
You must be signed in to change notification settings - Fork 4
feat(Streams): add methods and types for Streams #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
scripts/open-api/generate-types.mjs
Outdated
| /** @todo update to production when released */ | ||
| url: 'https://transfer.api.test.globuscs.info/v2/openapi.json', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this can be swapped now – https://transfer.api.globus.org/v2/openapi.json
| return serviceRequest( | ||
| { | ||
| service: ID, | ||
| scope: SCOPES.ALL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swap scope for resource_server: RESOURCE_SERVERS.TRANSFER
globus-sdk-javascript/src/services/shared.ts
Lines 32 to 45 in ce6b745
| /** | |
| * A specific scope that is required for the request. If a scope is provided, | |
| * the `serviceRequest` function will attempt to get a token for the request | |
| * based on the the `service` => `resource_server` mapping. | |
| * @deprecated Define using `resource_server` instead. | |
| */ | |
| scope?: string; | |
| /** | |
| * The resource server that the request will be made to. This can be provided | |
| * instead of (or addition to) the `scope` property. If this is provided, the | |
| * `serviceRequest` function will attempt to get a token for the resource server | |
| * when a `manager` instance is provided in the SDK options. | |
| */ | |
| resource_server?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why I didn't get that deprecation warning. Fixed now.
| /** | ||
| * Start a tunnel that's in the `AWAITING_LISTENER` state. | ||
| */ | ||
| export const start = function ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure if we should just have an update method that takes a standard options, where the consumer has to build the entire payload, or more RPC-like calls likes this.
🤖 I have created a release *beep* *boop* --- ## [6.2.0](v6.1.0...v6.2.0) (2025-11-18) ### Features * **Search, Typescript:** add type generic to search.query.post ([#647](#647)) ([94133f2](94133f2)) * **Streams:** add methods and types for Streams ([#682](#682)) ([ee563ca](ee563ca)) ### Bug Fixes * **Transfer, Typescript:** transfer.endpointSearch return type ([#664](#664)) ([f001164](f001164)) * Update Compute host for OpenAPI spec and documentation ([#659](#659)) ([d7f614f](d7f614f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
No description provided.