Skip to content

Commit e1f23bf

Browse files
committed
PR updates.
1 parent 14cb93a commit e1f23bf

File tree

3 files changed

+25
-32
lines changed

3 files changed

+25
-32
lines changed

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ Suggestion: This initialization should be in singleton format because new initia
3131

3232
## Key Exchange
3333

34-
A key exchange request should be made at least once in the application's lifecycle. To perform this action, follow the example code shown below.
35-
3634
```kotlin
3735
class MainActivity : AppCompatActivity() {
3836

pos-client-library/src/main/java/com/globalaccelerex/globalaccelerexandroidposclientlibrary/GAClientLib.kt

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ class GAClientLib private constructor(
2323
private val countryCode: Countries
2424
) {
2525

26-
//variable to keep track of when key exchange has been made in the app.
27-
private var hasPerformedKeyExchange: Boolean = false
2826
private val TAG = "GAClientLib"
2927

3028
private val parametersRequest = ParameterRequest()
@@ -57,7 +55,6 @@ class GAClientLib private constructor(
5755
* [callingComponent] should be either [Fragment] or [Activity]
5856
* */
5957
fun makeParametersRequest(callingComponent: Activity) {
60-
makeKeyExchangeWarning()
6158
parametersRequest.performParameterRequest(callingComponent)
6259
}
6360

@@ -66,7 +63,6 @@ class GAClientLib private constructor(
6663
* [callingComponent] should be either [Fragment] or [Activity]
6764
* */
6865
fun makeParametersRequest(callingComponent: Fragment) {
69-
makeKeyExchangeWarning()
7066
parametersRequest.performParameterRequest(callingComponent)
7167
}
7268

@@ -76,7 +72,6 @@ class GAClientLib private constructor(
7672
* [callingComponent] should be either [Fragment] or [Activity]
7773
* */
7874
fun makeKeyExchangeRequest(callingComponent: Activity) {
79-
this.hasPerformedKeyExchange = true
8075
keyExchangeRequest.performKeyExchange(
8176
callingComponent = callingComponent
8277
)
@@ -87,7 +82,6 @@ class GAClientLib private constructor(
8782
* [callingComponent] should be either [Fragment] or [Activity]
8883
* */
8984
fun makeKeyExchangeRequest(callingComponent: Fragment) {
90-
this.hasPerformedKeyExchange = true
9185
keyExchangeRequest.performKeyExchange(
9286
callingComponent = callingComponent
9387
)
@@ -150,16 +144,4 @@ class GAClientLib private constructor(
150144
}
151145
}
152146

153-
/**
154-
* Warning: Key exchange must be made at least once in the application's lifecycle
155-
* */
156-
private fun makeKeyExchangeWarning() {
157-
if (!hasPerformedKeyExchange) {
158-
Log.d(
159-
TAG,
160-
"It seems key exchange hasn't been made during this session. Make sure that is done at least once in the application's lifecycle"
161-
)
162-
}
163-
}
164-
165147
}

pos-client-library/src/main/java/com/globalaccelerex/globalaccelerexandroidposclientlibrary/baseAppUtils/Models.kt

Lines changed: 25 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,33 @@ package com.globalaccelerex.globalaccelerexandroidposclientlibrary.baseAppUtils
22

33
import com.globalaccelerex.globalaccelerexandroidposclientlibrary.baseAppUtils.BaseAppConstants.MOBILE_MONEY_STATUS_CHECK
44
import com.globalaccelerex.globalaccelerexandroidposclientlibrary.util.RequestStatus
5+
import com.google.gson.annotations.SerializedName
56

67
data class PosParameters(
7-
val BankLogo: String?,
8-
val BankName: String?,
9-
val BillerID: String?,
10-
val City: String?,
11-
val FooterMessage: String?,
12-
val MerchantAddress: String?,
13-
val MerchantCategoryCode: String?,
14-
val MerchantID: String?,
15-
val MerchantName: String?,
16-
val PTSP: String?,
17-
val State: String?,
18-
val TerminalID: String?,
8+
@SerializedName("BankLogo")
9+
val bankLogo: String?,
10+
@SerializedName("BankName")
11+
val bankName: String?,
12+
@SerializedName("BillerID")
13+
val billerID: String?,
14+
@SerializedName("City")
15+
val city: String?,
16+
@SerializedName("FooterMessage")
17+
val footerMessage: String?,
18+
@SerializedName("MerchantAddress")
19+
val merchantAddress: String?,
20+
@SerializedName("merchantCategoryCode")
21+
val merchantCategoryCode: String?,
22+
@SerializedName("MerchantID")
23+
val merchantID: String?,
24+
@SerializedName("MerchantName")
25+
val merchantName: String?,
26+
@SerializedName("PTSP")
27+
val ptsp: String?,
28+
@SerializedName("State")
29+
val state: String?,
30+
@SerializedName("TerminalID")
31+
val terminalID: String?,
1932
val baseAppVersion: String?,
2033
val serialNumber: String?
2134
)

0 commit comments

Comments
 (0)