New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify or refute that keyword mutes apply to lists #409

Open

hannahwhy opened this issue Apr 1, 2018 · 1 comment

Labels

bug enhance ft-keyword mute

Member

hannahwhy commented Apr 1, 2018

I've received reports that keyword mutes work on lists, which is probably desirable behavior but I have no idea how they're working.

Write some specs to exercise these code paths, and make sure you know how to make those specs fail if they don't fail outright.

hannahwhy added ft-keyword mute enhance bug labels

Member Author

hannahwhy commented Jun 14, 2018 •

edited

Loading

Keyword mutes (actually, all filtering options) apply to lists because FeedInsertWorker treats lists with the same filtering logic as the home feed. See https://github.com/glitch-soc/mastodon/blob/master/app/workers/feed_insert_worker.rb#L25-L41 for details.

I still think it makes sense to write a spec for this, though the existing specs in FeedInsertWorker are a bit thin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment