Skip to content

Commit 24441c2

Browse files
Select Header styling fix
1 parent 8cc394e commit 24441c2

File tree

5 files changed

+12
-3
lines changed

5 files changed

+12
-3
lines changed

.changeset/serious-dolls-travel.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'polaris-glints': minor
3+
'@shopify/stylelint-polaris': minor
4+
---
5+
6+
IndexTable styling changes

polaris-react/src/components/CheckableButton/CheckableButton.scss

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
@import '../ResourceList/variables';
33

44
$button-vertical-padding: calc(
5-
(36px - var(--p-font-line-height-2) - var(--p-space-05)) / 2
5+
(38px - var(--p-font-line-height-2) - var(--p-space-05)) / 2
66
);
77

88
.CheckableButton {
@@ -61,7 +61,8 @@ $button-vertical-padding: calc(
6161
overflow: hidden;
6262
max-width: 100%;
6363
text-overflow: ellipsis;
64-
font-size: var(--p-font-size-100);
64+
font-size: var(--p-font-size-200);
65+
font-weight: var(--p-font-weight-semibold);
6566
font-family: 'Noto Sans TC', 'Noto Sans SC', 'Noto Sans KR', 'Noto Sans JP',
6667
'Noto Sans', sans-serif;
6768
// padding to fix the bottom of letters being cutoff by overflow: hidden

polaris-react/src/components/CheckableButton/CheckableButton.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ export const CheckableButton = forwardRef(function CheckableButton(
5050
checkbox?.({
5151
onChange: onToggleAll,
5252
checked: selected,
53+
indeterminate: selected === 'indeterminate',
5354
})
5455
) : (
5556
<Checkbox

polaris-react/src/components/IndexTable/IndexTable.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@ $loading-panel-height: 53px;
604604
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
605605
right: 0;
606606
padding: 0 var(--p-space-2) 0 calc(var(--p-space-3) - var(--p-space-025));
607-
background: var(--p-surface);
607+
background: #f8fafc;
608608

609609
&.StickyTableHeader-condensed {
610610
padding-top: calc(var(--p-space-2) + var(--p-space-05));

polaris-react/src/components/IndexTable/IndexTable.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ export interface IndexTableHeadingCheckbox {
6666
label?: string;
6767
onChange?: (checked: boolean) => unknown;
6868
checked?: boolean | 'indeterminate';
69+
indeterminate?: boolean;
6970
}
7071

7172
export interface IndexTableBaseProps {

0 commit comments

Comments
 (0)