Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #630 basic service mesh support for Consul #664

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

evisong
Copy link

@evisong evisong commented Jul 21, 2019

This PR is trying to implement #630.

Consul ServiceMesh Support

Consul can support ServiceMesh by integrating with proxies like Envoy, the most convenient way to enable this capability is creating a Service like this:

{
 "service": {
   "name": "web",
   "port": 8080,
   "connect": { "sidecar_service": {} }
 }
}

Then Consul will automatically generate a corresponding SidecarService with default configurations.

In Registrator, you may add the "connect": { "sidecar_service": {} } configuration by the -service-mesh flag. It's also overridable by SERVICE_MESH.

Your feedbacks are appreciated.

@vilva42
Copy link

vilva42 commented Dec 12, 2019

@evisong if I understand correctly, -service-mesh and SERVICE_MESH are both representing the same boolean? also is the SERVICE_MESH variable specific to registrator or the container? If it is specific to containers, it would be nice to have a default value of connect": { "sidecar_service": {} } but can be overridden to add upstreams. Most of our containers do not need a sidecar and if they do, they may or may not have upstreams. If there's another way to add upstreams, let us know. Appreciate your work.

@evisong
Copy link
Author

evisong commented Jun 28, 2020

if I understand correctly, -service-mesh and SERVICE_MESH are both representing the same boolean? also is the SERVICE_MESH variable specific to registrator or the container? If it is specific to containers, it would be nice to have a default value of connect": { "sidecar_service": {} } but can be overridden to add upstreams. Most of our containers do not need a sidecar and if they do, they may or may not have upstreams. If there's another way to add upstreams, let us know. Appreciate your work.

@vilva42 Sorry for the super-late response. Could you please elaborate on the expected format of upstream configurations? Btw, my dev environment is not available right now, please expect another late response 😢

@vilva42
Copy link

vilva42 commented Jun 28, 2020

hey @evisong Thanks for the response. We decided not to use registrator for this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants