Add availibity to add default attrs #636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianb
force-pushed
the
issue_635_add_attrs_using_consul
branch
from
07e7416
to
b2e43c7
Compare
bastianb
commented
Aug 16, 2018
bridge/util.go
Outdated
| meta := config.Env | ||
| for k, v := range config.Labels { | ||
| meta = append(meta, k+"="+v) | ||
| } | ||
| metadata := make(map[string]string) | ||
| metadataFromPort := make(map[string]bool) | ||
|
|
||
| for _, kv := range strings.Split(default_attrs, ",") { |
There was a problem hiding this comment.
In my use case container attrs from env or labels should override the default "forced" attrs.
So I am not sure if the name in the doc make sense, or if container should not override them, meaning that I should move this below.
What do you think?
bastianb
commented
Aug 16, 2018
| @@ -44,6 +44,7 @@ Guide. Typically, running Registrator looks like this: | |||
| Usage of /bin/registrator: | |||
| /bin/registrator [options] <registry URI> | |||
|
|
|||
| -attrs="": Append attrs (ServiceMeta) for all registered services (only for consul) | |||
There was a problem hiding this comment.
looks like that:
registrator --attrs "key_1=something,key_2=something_else"
Should I add more detail in the doc?
bastianb
force-pushed
the
issue_635_add_attrs_using_consul
branch
from
b2e43c7
to
6795a50
Compare
bastianb
force-pushed
the
issue_635_add_attrs_using_consul
branch
from
6795a50
to
bed7fa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #635
Its my first golang writing session would be glad to have feedback
idea is to have --attrs "attr_1=some_value,attr_2=someother_value,....." so each service have default ServiceMeta in consul.