Build images from heroku/heroku:STACK-build images and drop support for heroku-20 and heroku-22 #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegonzalez
changed the title
Rather than try and emulate the work heroku is doing, use their upstream images as is. This simplifies the build process signficantly, and allows us to only layer the necessary on top of their images. This was not previously possible due to missing arm64 support, which is introduced in the heroku-24 stack. Thus, this will fail for all other stacks.
josegonzalez
force-pushed
the
simplify-build
branch
from
f00903c
to
0e6dce9
Compare
edmorley
reviewed
Aug 26, 2024
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than try and emulate the work heroku is doing, use their upstream images as is. This simplifies the build process signficantly, and allows us to only layer the necessary on top of their images.
This was not previously possible due to missing arm64 support, which is introduced in the heroku-24 stack. Thus, this will fail for all other stacks.