Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaration of Galahad\LaravelAddressing\Collection\CountryCollection::pop() #32

Closed
seabasss opened this issue Aug 4, 2021 · 4 comments

Comments

@seabasss
Copy link

seabasss commented Aug 4, 2021

Hello,

I'm getting this after updating to latest Laravel:

Declaration of Galahad\LaravelAddressing\Collection\CountryCollection::pop(): ?Galahad\LaravelAddressing\Entity\Country must be compatible with Illuminate\Support\Collection::pop($count = 1)

Here's the pull request and changelog:
laravel/framework#38093
https://github.com/laravel/framework/blob/8.x/CHANGELOG-8.x.md#added

Would it be possible to patch the pop and shift methods? Thank you!

@inxilpro
Copy link
Contributor

inxilpro commented Aug 4, 2021

This will be addressed in version 3.0.0 (which mostly just drops support for older Laravel and PHP versions—no other major changes).

@inxilpro inxilpro closed this as completed Aug 4, 2021
@seabasss
Copy link
Author

seabasss commented Aug 4, 2021

Cool! When is v3 released? Thank you!

@inxilpro
Copy link
Contributor

inxilpro commented Aug 4, 2021

It's out now :)

@seabasss
Copy link
Author

seabasss commented Aug 4, 2021

Sweet, thank you! Worked like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants