Better error messages when trying to load a bad options file

Author: ShadSterling

mocha-multi.js

@@ -47,6 +47,7 @@ const msgs = {
   invalid_reporter: "Unable to find '%s' reporter",
   invalid_setup: "Invalid setup for reporter '%s' (%s)",
   invalid_outfile: "Invalid stdout filename for reporter '%s' (%s)",
+  bad_file: "Missing or malformed options file '%s' -- %s",
 };
 function bombOut(id, ...args) {
   const newArgs = [`ERROR: ${msgs[id]}`, ...args];
@@ -67,7 +68,11 @@ function convertSetup(reporters) {
   Object.keys(reporters).forEach((reporter) => {
     if (reporter === 'mocha-multi') {
       debug('loading reporters from file %j', reporters[reporter]);
-      setup = setup.concat(convertSetup(JSON.parse(fs.readFileSync(reporters[reporter]))));
+      try {
+        setup = setup.concat(convertSetup(JSON.parse(fs.readFileSync(reporters[reporter]))));
+      } catch (e) {
+        bombOut('bad_file', reporters[reporter], e);
+      }
     } else {
       const r = reporters[reporter];
       debug('adding reporter %j %j', reporter, r);

verify

@@ -104,6 +104,16 @@ function compare {
   fi
 }
 
+badfilecheck="ERROR: Missing or malformed options file 'missing.json' -- Error: ENOENT: no such file or directory, open 'missing.json'"
+badfile=`mocha --reporter "$mocha_multi" --reporter-options mocha-multi=missing.json --recursive test 2>&1`
+log "$badfile"
+if [ "$badfile" != "$badfilecheck" ]; then
+  log "Wrong error message trying to load missing options file" fail
+  exit 1
+else
+  log "Correct error message trying to load missing options file" pass
+fi
+
 if [ "$1" = "" ]; then
   log "No reporter chosen"
   exit 1