Skip to content

Commit c3ece39

Browse files
authored
bump to 1.2.2 and prepare for future changes to TS.MGET (palicao#12)
1 parent 509d298 commit c3ece39

File tree

3 files changed

+22
-17
lines changed

3 files changed

+22
-17
lines changed

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ services:
1111
- .:/app
1212
redis:
1313
container_name: redis
14-
image: redislabs/redistimeseries:1.2.1
14+
image: redislabs/redistimeseries:1.2.2

src/TimeSeries.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,12 @@ public function getLastSamples(Filter $filter): array
337337
);
338338
$samples = [];
339339
foreach ($results as $result) {
340-
$samples[] = Sample::createFromTimestamp($result[0], (float)$result[3], (int)$result[2]);
340+
// most recent versions of TS.MGET return results in a nested array
341+
if (count($result) === 3) {
342+
$samples[] = Sample::createFromTimestamp($result[0], (float)$result[2][1], (int)$result[2][0]);
343+
} else {
344+
$samples[] = Sample::createFromTimestamp($result[0], (float)$result[3], (int)$result[2]);
345+
}
341346
}
342347
return $samples;
343348
}

tests/Integration/IntegrationTest.php

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ public function setUp(): void
3535

3636
public function testAddAndRetrieveAsRange(): void
3737
{
38-
$from = new DateTimeImmutable('2019-11-06 20:34:17.103000');
39-
$to = new DateTimeImmutable('2019-11-06 20:34:17.107000');
38+
$from = new DateTimeImmutable('2019-11-06 20:34:17.000');
39+
$to = new DateTimeImmutable('2019-11-06 20:34:17.100');
4040

4141
$this->sut->create(
4242
'temperature:3:11',
@@ -51,21 +51,21 @@ public function testAddAndRetrieveAsRange(): void
5151
$from,
5252
$to,
5353
null,
54-
new AggregationRule(AggregationRule::AGG_AVG, 5)
54+
new AggregationRule(AggregationRule::AGG_AVG, 10)
5555
);
5656

5757
$expectedRange = [
58-
new Sample('temperature:3:11', 30, new DateTimeImmutable('2019-11-06 20:34:17.100000')),
59-
new Sample('temperature:3:11', 42, new DateTimeImmutable('2019-11-06 20:34:17.105000'))
58+
new Sample('temperature:3:11', 30, new DateTimeImmutable('2019-11-06 20:34:17.000')),
59+
new Sample('temperature:3:11', 42, new DateTimeImmutable('2019-11-06 20:34:17.100'))
6060
];
6161

6262
$this->assertEquals($expectedRange, $range);
6363
}
6464

6565
public function testAddAndRetrieveAsMultiRangeWithMultipleFilters(): void
6666
{
67-
$from = new DateTimeImmutable('2019-11-06 20:34:17.103000');
68-
$to = new DateTimeImmutable('2019-11-06 20:34:17.107000');
67+
$from = new DateTimeImmutable('2019-11-06 20:34:17.000');
68+
$to = new DateTimeImmutable('2019-11-06 20:34:17.100');
6969

7070
$this->sut->create(
7171
'temperature:3:11',
@@ -81,17 +81,17 @@ public function testAddAndRetrieveAsMultiRangeWithMultipleFilters(): void
8181
$range = $this->sut->multiRange($filter);
8282

8383
$expectedRange = [
84-
new Sample('temperature:3:11', 30, new DateTimeImmutable('2019-11-06 20:34:17.103000')),
85-
new Sample('temperature:3:11', 42, new DateTimeImmutable('2019-11-06 20:34:17.107000'))
84+
new Sample('temperature:3:11', 30, new DateTimeImmutable('2019-11-06 20:34:17.000')),
85+
new Sample('temperature:3:11', 42, new DateTimeImmutable('2019-11-06 20:34:17.100'))
8686
];
8787

8888
$this->assertEquals($expectedRange, $range);
8989
}
9090

9191
public function testAddAndRetrieveAsLastSamplesWithMultipleFilters(): void
9292
{
93-
$from = new DateTimeImmutable('2019-11-06 20:34:17.103000');
94-
$to = new DateTimeImmutable('2019-11-06 20:34:17.107000');
93+
$from = new DateTimeImmutable('2019-11-06 20:34:17.000');
94+
$to = new DateTimeImmutable('2019-11-06 20:34:18.000');
9595

9696
$this->sut->create(
9797
'temperature:3:11',
@@ -115,17 +115,17 @@ public function testAddAndRetrieveAsLastSamplesWithMultipleFilters(): void
115115
$range = $this->sut->getLastSamples($filter);
116116

117117
$expectedResult = [
118-
new Sample('temperature:3:11', 42, new DateTimeImmutable('2019-11-06 20:34:17.107000')),
119-
new Sample('temperature:3:12', 42, new DateTimeImmutable('2019-11-06 20:34:17.107000'))
118+
new Sample('temperature:3:11', 42, new DateTimeImmutable('2019-11-06 20:34:18.000')),
119+
new Sample('temperature:3:12', 42, new DateTimeImmutable('2019-11-06 20:34:18.000'))
120120
];
121121

122122
$this->assertEquals($expectedResult, $range);
123123
}
124124

125125
public function testAddAndRetrieveKeysWithMultipleFilters(): void
126126
{
127-
$from = new DateTimeImmutable('2019-11-06 20:34:17.103000');
128-
$to = new DateTimeImmutable('2019-11-06 20:34:17.107000');
127+
$from = new DateTimeImmutable('2019-11-06 20:34:17.000');
128+
$to = new DateTimeImmutable('2019-11-06 20:34:17.100');
129129

130130
$this->sut->create(
131131
'temperature:3:11',

0 commit comments

Comments
 (0)