Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEP-0384: OMEMO Encryption 0.4.0+ #25

Open
Neustradamus opened this issue Mar 26, 2020 · 11 comments
Open

XEP-0384: OMEMO Encryption 0.4.0+ #25

Neustradamus opened this issue Mar 26, 2020 · 11 comments

Comments

@Neustradamus
Copy link
Contributor

Neustradamus commented Mar 26, 2020

Can you update the XEP-0384: OMEMO Encryption support to 0.4.0+?

And XEP-0454: OMEMO Media sharing:

Diff Tool:

PS: Not sure that 0.3.0 was complete before:

@Neustradamus Neustradamus changed the title XEP-0384: OMEMO Encryption 0.4.0 XEP-0384: OMEMO Encryption 0.5.0 Mar 30, 2020
@Neustradamus Neustradamus changed the title XEP-0384: OMEMO Encryption 0.5.0 XEP-0384: OMEMO Encryption 0.3.0+ Nov 28, 2020
@Neustradamus Neustradamus changed the title XEP-0384: OMEMO Encryption 0.3.0+ XEP-0384: OMEMO Encryption 0.4.0+ Nov 30, 2020
@gkdr
Copy link
Owner

gkdr commented Dec 2, 2020

as far as i know there is no client implementing this. am i wrong?

@selurvedu
Copy link

selurvedu commented Dec 2, 2020

as far as i know there is no client implementing this

Yes

@Neustradamus
Copy link
Contributor Author

@gkdr
Copy link
Owner

gkdr commented Dec 2, 2020

nice, that means the libsignal-protocol-c fork is functional as well?

@Neustradamus
Copy link
Contributor Author

@gkdr: First, I can not confirm that current libomemo supports a perfect OMEMO 0.3.0, only you can confirm it.

About OMEMO 0.4.0+, I am not sure that the omemo1 branch of Dino is up-to-date.
It is important to create a new libomemo branch for OMEMO 0.4.0+ or better, I think, a new repo, for example "libomemo-v2" or other...

@mar-v-in: Please talk with @gkdr.

Thanks in advance.

@mar-v-in
Copy link

mar-v-in commented Dec 3, 2020

libomemo-c should work, but afaik it was not thoroughly tested with for compatibility any other implementation yet. When operating based on libomemo-c, you can implement omemo 0.3.0 and 0.4.0+ at the same time so that your client remains fully backwards-compatible. This is what is implemented in omemo1 branch, but again, nothing of this was thoroughly tested and you'd be the first client to implement this in production.

@gkdr
Copy link
Owner

gkdr commented Dec 4, 2020

oh, nice, thanks for that! the changes look like i can probably plug it into my signal-protocol-client-code with little adaptations. i can also start implementing the pure xml stuff here, but will think about how to include the forked signal protocol since it's now part of the omemo spec.

@hades
Copy link

hades commented Oct 7, 2023

Is this fixed now (after 6f153c0 and further changes last year)?

@Neustradamus
Copy link
Contributor Author

@hades: Sorry for the delay, it does not support OMEMO 0.8.3, it is only 0.3.0.

And "XEP-0454: OMEMO Media sharing" is missing too:

Maybe some guys can look it?

All links in description.

cc: @root-hardenedvault, @hartwork, @fortysixandtwo.

@Neustradamus
Copy link
Contributor Author

I think it is time to update the lib with latest XEP-0384 version.

People would like the support of the latest version.

@gkdr
Copy link
Owner

gkdr commented Aug 31, 2024

@Neustradamus I agree the newest version would be nice. As mentioned above, this would require using the omemo-specific crypto in a completely different place than here (as this module only dealt with the XML protocol and left the crypto to a libsignal-protocol-c wrapper). Not sure what the newest versions add beyond that, is there a good implementation guide somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants