Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold link in italics followed by a period #53

Closed
regseb opened this issue Oct 6, 2017 · 2 comments
Closed

Bold link in italics followed by a period #53

regseb opened this issue Oct 6, 2017 · 2 comments

Comments

@regseb
Copy link

regseb commented Oct 6, 2017

Hello,

A bold link in italics followed by a period prints a roman regular link wrapped by ***.

This code :

require 'commonmarker'

print(CommonMarker.render_html('***[foo](http://bar.baz/)***.', :DEFAULT))

print(CommonMarker.render_html('***[foo](http://bar.baz/)***', :DEFAULT))
print(CommonMarker.render_html('**[foo](http://bar.baz/)**.', :DEFAULT))
print(CommonMarker.render_html('*[foo](http://bar.baz/)*.', :DEFAULT))
print(CommonMarker.render_html('***foo***.', :DEFAULT))

prints :

***foo***.

foo

foo.

foo.

foo.

@gjtorikian
Copy link
Owner

Hello! Good catch. This appears to be a problem upstream with the C cmark lib. This Ruby gem simply wraps that C library, so I would suggest opening an issue up there.

I was able to confirm this with these two links generating text which also follow the CommonMark spec:

  • http://spec.commonmark.org/dingus/?text=***%5Bfoo%5D(http%3A%2F%2Fbar.baz%2F)***
  • http://spec.commonmark.org/dingus/?text=***%5Bfoo%5D(http%3A%2F%2Fbar.baz%2F)***.

@regseb
Copy link
Author

regseb commented Oct 8, 2017

I open an issue on cmark : commonmark/cmark#237.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants