Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.99.6-1.deb] Color file-picker #1030

Closed
ghost opened this issue Jul 22, 2020 · 8 comments
Closed

[0.99.6-1.deb] Color file-picker #1030

ghost opened this issue Jul 22, 2020 · 8 comments

Comments

@ghost
Copy link

ghost commented Jul 22, 2020

The color file-picker icon which is proposed in the font custom color panel has no effect, at least in linux/KDE.
Then maybe better remove it until problem identified ? (...not a key feature).

@ForeverRainbow
Copy link
Contributor

See: #896 its not yet implemented

@ghost
Copy link
Author

ghost commented Jul 24, 2020

It does not look obvious at all that #896 has something related to a color-picker feature, but if you mean the root cause is the same, it's fine, we'll see.
Let's say... to be confirmed.

https://i.imgur.com/qbjI7XM.png

@ForeverRainbow
Copy link
Contributor

Ah right sorry, didnt realize what you meant. I would guess they have the same root cause of not being implemented as part of the whole theme stuff yet

@txe
Copy link
Contributor

txe commented Jul 27, 2020

The screenshot is really helpful. This color-picker feature exists only on KDE systems, on XFCE/linux or windows there is no such button.
So far, I could manage to find something about the issue on kubuntu forum. I don't see any options to turn it off or fix it.

@txe txe closed this as completed Jul 27, 2020
@ghost
Copy link
Author

ghost commented Jul 27, 2020

If it can help later, this is the message I get:

(cherrytree:6457): Gtk-WARNING **: 
Attempting to add a widget with type gtkmm__GtkColorChooserDialog to a gtkmm__GtkApplicationWindow,
but asa GtkBin subclass a gtkmm__GtkApplicationWindow can only contain one widget at a time; 
it already contains a widget of type gtkmm__GtkVBox
[GTK Logger] [warning] This object, of type gtkmm__GtkColorChooserDialog, already has a wrapper.
You should use wrap() instead of a constructor.

Just in case it can help later on.
Minor issue.

@txe txe reopened this Jul 27, 2020
@txe
Copy link
Contributor

txe commented Jul 27, 2020

Yeah, I took a look at other warnings in console, the important one is
the GVariant format string '(u)' has a type of '(u)' but the given value has a type of '((u))'

Actually, GIMP uses controls similar to Gtk and had the same issue and the fix for it.

There is the same problematic place g_variant_get (retval, "(u)", &color); in Gtk code.
So, if you take this data and create an issue on https://gitlab.gnome.org, then it can be easily fixed by them.

@ghost
Copy link
Author

ghost commented Jul 27, 2020

Hummm... in fact I've never used gnome, and don't use gimp at all.
I am not sure to be very welcomed @ gitlab.gnome.org as a KDE user.
From my point of view, this is minor, it was just a warning in case of potential interest.
I even don't know what this color-picker is supposed to open, and totally don't understand how this icon can be visible in KDE environment only.
It's all I can do to help on that one. You can re-close this issue if you want !

@txe
Copy link
Contributor

txe commented Jul 27, 2020

gnome will welcome it:

  • code from gtkcolorpickerkwin.c , kwin` means KDE windows, so it's a widget specially made for KDE window system.
  • they don't a lot of people to test and then to fix issues, so to get an issue and the fix for it (to change a couple of symbols) at once should be appreciated.

But it's up to you, closing this.

@txe txe closed this as completed Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants