Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of mktemp #56

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Replace use of mktemp #56

merged 1 commit into from
Dec 13, 2023

Commits on Dec 13, 2023

  1. Replace use of mktemp 

    This uses NamedTemporaryFile with delete=False to replace the one
use of the deprecated mktemp function in smmap (reported in gitpython-developers#41).

This avoids the race condition inherent to mktemp, as the file is
named and created together in a way that is effectively atomic.

Because NamedTemporaryFile is not being used to automatically
delete the file, it use and cleanup are unaffected by the change.
    @EliahKagan
    EliahKagan committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a315725 View commit details
    Browse the repository at this point in the history