Skip to content

Updating regex pattern to handle unicode whitespaces. #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Updating regex pattern to handle unicode whitespaces. #1853

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ca0fba
Updating regex pattern to handle unicode whitespaces.
Mar 1, 2024
827e986
Updating spacing per linting test.
Mar 1, 2024
4810491
Fixing Windows encoding issue.
Mar 5, 2024
938f272
Setting universal_newlines=False explicitly in fetch() and pull().
Mar 5, 2024
8b8c76a
Fixing stripping issue causing passing tests to be interpreted as fai…
Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Setting universal_newlines=False explicitly in fetch() and pull(). 
This fix avoids encoding problems on Windows, as was done for fetch() in the previous commit. However, here it is being made more explicit and adds the same fix for the pull function.
  • Loading branch information
jcole-crowdstrike committed Mar 8, 2024
commit 938f2725eb137492a459b4210ae58565e26e4fd5
4 changes: 2 additions & 2 deletions git/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,7 +1068,7 @@ def fetch(
Git.check_unsafe_options(options=list(kwargs.keys()), unsafe_options=self.unsafe_git_fetch_options)

proc = self.repo.git.fetch(
"--", self, *args, as_process=True, with_stdout=False, v=verbose, **kwargs
"--", self, *args, as_process=True, with_stdout=False, universal_newlines=False, v=verbose, **kwargs
)
res = self._get_fetch_info_from_stderr(proc, progress, kill_after_timeout=kill_after_timeout)
if hasattr(self.repo.odb, "update_cache"):
Expand Down Expand Up @@ -1122,7 +1122,7 @@ def pull(
Git.check_unsafe_options(options=list(kwargs.keys()), unsafe_options=self.unsafe_git_pull_options)

proc = self.repo.git.pull(
"--", self, refspec, with_stdout=False, as_process=True, universal_newlines=True, v=True, **kwargs
"--", self, refspec, with_stdout=False, as_process=True, universal_newlines=False, v=True, **kwargs
)
res = self._get_fetch_info_from_stderr(proc, progress, kill_after_timeout=kill_after_timeout)
if hasattr(self.repo.odb, "update_cache"):
Expand Down