Skip to content

Add __all__ in git.exc #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Add __all__ in git.exc #1719

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8197e90
Remove now-unused import in top-level __init__.py
EliahKagan Oct 20, 2023
7545b80
Add __all__ in git.exc, adjust __init__.py imports
EliahKagan Oct 20, 2023
2af3679
Remove `@UnusedImport` from an import that is used
EliahKagan Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove now-unused import in top-level __init__.py 
The inspect module was only used to dynamically generate __all__,
which is statically written since c862845. Although it includes
everything it originally had for compatibility (8edc53b), this did
not include modules, since the comprehension used to generate it
omitted those (which is what it needed the inspect module for).
So it was not, and is not, listed in __all__, and can be removed.
  • Loading branch information
@EliahKagan
EliahKagan committed Oct 20, 2023
commit 8197e9043f26a88168dc3227c4fbb0ec64ef42f9
1 change: 0 additions & 1 deletion git/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
# flake8: noqa
# @PydevCodeAnalysisIgnore
from git.exc import * # @NoMove @IgnorePep8
import inspect
import os
import sys
import os.path as osp
Expand Down