Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use venv instead of virtualenv in test_installation #1664

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Use venv instead of virtualenv in test_installation #1664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use venv instead of virtualenv in test_installation 
This eliminates the test dependency on virtualenv by using the
standard library venv module instead in test_installation.
  • Loading branch information
@EliahKagan
EliahKagan committed Sep 17, 2023
commit ad76c99d73ecee3b834beea81ad78665b849adf8
1 change: 0 additions & 1 deletion test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@ pre-commit
pytest
pytest-cov
pytest-sugar
virtualenv
4 changes: 3 additions & 1 deletion test/test_installation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import ast
import os
import subprocess
import sys

from git.compat import is_win
from test.lib import TestBase
from test.lib.helper import with_rw_directory
Expand All @@ -12,7 +14,7 @@
class TestInstallation(TestBase):
def setUp_venv(self, rw_dir):
self.venv = rw_dir
subprocess.run(["virtualenv", self.venv], stdout=subprocess.PIPE)
subprocess.run([sys.executable, "-m", "venv", self.venv], stdout=subprocess.PIPE)
bin_name = "Scripts" if is_win else "bin"
self.python = os.path.join(self.venv, bin_name, "python")
self.pip = os.path.join(self.venv, bin_name, "pip")
Expand Down