Skip to content

Adding inital types to remote.py #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 7, 2021
Merged

Adding inital types to remote.py #1229

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ad4079d
add types to base.py and fun.py
Yobmod Feb 28, 2021
5b0028e
start add types to util.py
Yobmod Feb 28, 2021
a094ac1
add types to git.util and git.__init__
Yobmod Mar 1, 2021
71e28b8
add types to git.db and git.exc
Yobmod Mar 1, 2021
2fd9f6e
add types to git.compat and git.diff
Yobmod Mar 2, 2021
6752fad
add initial types to remote.py
Yobmod May 3, 2021
18b75d9
copy sys.version checks for literal and final to git.types
Yobmod May 3, 2021
a1fa850
update type of FetchInfo.refresh() to use Literal
Yobmod May 3, 2021
c08f592
add types to PushInfo.__init__() .remote_ref() and .old_commit()
Yobmod May 3, 2021
f8e7a7d
Merge branch 'main' into addtypes
Yobmod May 3, 2021
baec2e2
make progress types more general
Yobmod May 3, 2021
8611488
Merge branch 'addtypes' of https://github.com/Yobmod/GitPython into a…
Yobmod May 3, 2021
e37ebaa
change a type (Commit) to a forward ref
Yobmod May 3, 2021
f97d378
change flags type to int
Yobmod May 3, 2021
90fefb0
add overloads to to_progress_instance()
Yobmod May 3, 2021
559ddb3
add types to _from_line()
Yobmod May 3, 2021
1b16037
second pass of adding types
Yobmod May 3, 2021
96f8f17
fix Repo forward ref
Yobmod May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add types to PushInfo.__init__() .remote_ref() and .old_commit()
  • Loading branch information
@Yobmod
Yobmod committed May 3, 2021
commit c08f592cc0238054ec57b6024521a04cf70e692f
8 changes: 4 additions & 4 deletions git/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ class PushInfo(object):
'=': UP_TO_DATE,
'!': ERROR}

def __init__(self, flags, local_ref, remote_ref_string, remote, old_commit=None,
summary=''):
def __init__(self, flags: Set[int], local_ref: SymbolicReference, remote_ref_string: str, remote,
old_commit: Optional[bytes] = None, summary: str = '') -> None:
""" Initialize a new instance """
self.flags = flags
self.local_ref = local_ref
Expand All @@ -126,11 +126,11 @@ def __init__(self, flags, local_ref, remote_ref_string, remote, old_commit=None,
self.summary = summary

@property
def old_commit(self):
def old_commit(self) -> Optional[bool]:
return self._old_commit_sha and self._remote.repo.commit(self._old_commit_sha) or None

@property
def remote_ref(self):
def remote_ref(self) -> Union[RemoteReference, TagReference]:
"""
:return:
Remote Reference or TagReference in the local repository corresponding
Expand Down