Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gitpython-developers/GitPython
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a083e8115807ff0a9b08a81d53e56190003e5354
Choose a base ref
...
head repository: gitpython-developers/GitPython
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5f889c4137d1d4442ab3ceb8e45c3c03cafded1a
Choose a head ref
  • 12 commits
  • 17 files changed
  • 4 contributors

Commits on Mar 1, 2024

  1. Updating regex pattern to handle unicode whitespaces.

    Replacing the \s whitespace characters with normal spaces (" ") to prevent breaking on unicode whitespace characters (e.g., NBSP). Without this, if a branch name contains a unicode whitespace character that falls under \s, then the branch name will be truncated.
    jcole-crowdstrike committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    5ca0fba View commit details
    Browse the repository at this point in the history
  2. Updating spacing per linting test.

    Adding a second blank line after the newly added test case.
    jcole-crowdstrike committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    827e986 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Fixing Windows encoding issue.

    Stdout is being encoded as Windows-1251 instead of UTF-8 due to passing
    universal_newlines as True to subprocess.
    jcole-crowdstrike committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4810491 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Setting universal_newlines=False explicitly in fetch() and pull().

    This fix avoids encoding problems on Windows, as was done for fetch() in the previous commit. However, here it is being made more explicit and adds the same fix for the pull function.
    jcole-crowdstrike committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    938f272 View commit details
    Browse the repository at this point in the history
  2. Fixing stripping issue causing passing tests to be interpreted as fai…

    …lures
    
    Removing this block of code that strips away nonprintable ASCII characters, as it is causing some tests to fail inappropriately.
    
    Successful tests are identified by the suffix ", done", which is being removed from some messages due to this aforementioned block of code. The codeblock probably intends to just strip away traililng non-ASCII characters from strings, but does not break, and so will instead continue to iterate through the string and then strip away both printable/nonprintable ASCII; this is causing the loss of the ", done" because anytime a nonprintable character is anywhere but the end of the string then the entire section of string after the character is truncated.
    
    Looking back through commits, this codeblock was added in 882ebb1 as a workaround after the addition of universal_newlines. Seeing as we have removed universal_newlines in the previous commit, we can also remove this codeblock.
    
    In future, if something likw this is needed, then maybe a join that concatenates all printable ASCII characters would serve better (e.g., "".join(b for b in line if b >= 32)), instead of trying to cut out the nonprintable chars.
    jcole-crowdstrike committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    8b8c76a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Merge pull request #1853 from jcole-crowdstrike/fix-branch-name-regex…

    …-to-handle-nbsp
    
    Update regex pattern to handle unicode whitespaces.
    Byron authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    d40e7d0 View commit details
    Browse the repository at this point in the history
  2. Start fixing venv test fixture pip toml bug

    This is not yet a usable fix, because venv.create only supports
    upgrade_deps on Python 3.9 and higher.
    EliahKagan committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    dd8ee4f View commit details
    Browse the repository at this point in the history
  3. Upgrade test fixture pip in venv without upgrade_deps

    Because the upgrade_deps parameter to venv.create, as well as
    related functionality such as the EnvBuilder.upgrade_dependencies
    method that it uses, are only available starting in Python 3.9.
    
    This also puts the name of the VirtualEnvironment.__init__
    parameter for setting up pip in the test fixture virtual
    environment back from need_pip to with_pip, which may be more
    intuitive.
    EliahKagan committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    a262a06 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1864 from EliahKagan/pip-toml

    Use upgraded pip in test fixture virtual environment
    Byron authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    49cb48a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0b7f159 View commit details
    Browse the repository at this point in the history
  6. fixing lints / noqa

    Borda committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    aa9298a View commit details
    Browse the repository at this point in the history
  7. try: from typing import Literal

    Borda committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    5f889c4 View commit details
    Browse the repository at this point in the history
Loading