-
-
Notifications
You must be signed in to change notification settings - Fork 950
Comparing changes
Open a pull request
base repository: gitpython-developers/GitPython
base: a083e8115807ff0a9b08a81d53e56190003e5354
head repository: gitpython-developers/GitPython
compare: 5f889c4137d1d4442ab3ceb8e45c3c03cafded1a
- 12 commits
- 17 files changed
- 4 contributors
Commits on Mar 1, 2024
-
Updating regex pattern to handle unicode whitespaces.
Replacing the \s whitespace characters with normal spaces (" ") to prevent breaking on unicode whitespace characters (e.g., NBSP). Without this, if a branch name contains a unicode whitespace character that falls under \s, then the branch name will be truncated.
jcole-crowdstrike committedMar 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 5ca0fba - Browse repository at this point
Copy the full SHA 5ca0fbaView commit details -
Updating spacing per linting test.
Adding a second blank line after the newly added test case.
jcole-crowdstrike committedMar 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 827e986 - Browse repository at this point
Copy the full SHA 827e986View commit details
Commits on Mar 5, 2024
-
Fixing Windows encoding issue.
Stdout is being encoded as Windows-1251 instead of UTF-8 due to passing universal_newlines as True to subprocess.
jcole-crowdstrike committedMar 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 4810491 - Browse repository at this point
Copy the full SHA 4810491View commit details
Commits on Mar 8, 2024
-
Setting universal_newlines=False explicitly in fetch() and pull().
This fix avoids encoding problems on Windows, as was done for fetch() in the previous commit. However, here it is being made more explicit and adds the same fix for the pull function.
jcole-crowdstrike committedMar 8, 2024 Configuration menu - View commit details
-
Copy full SHA for 938f272 - Browse repository at this point
Copy the full SHA 938f272View commit details -
Fixing stripping issue causing passing tests to be interpreted as fai…
…lures Removing this block of code that strips away nonprintable ASCII characters, as it is causing some tests to fail inappropriately. Successful tests are identified by the suffix ", done", which is being removed from some messages due to this aforementioned block of code. The codeblock probably intends to just strip away traililng non-ASCII characters from strings, but does not break, and so will instead continue to iterate through the string and then strip away both printable/nonprintable ASCII; this is causing the loss of the ", done" because anytime a nonprintable character is anywhere but the end of the string then the entire section of string after the character is truncated. Looking back through commits, this codeblock was added in 882ebb1 as a workaround after the addition of universal_newlines. Seeing as we have removed universal_newlines in the previous commit, we can also remove this codeblock. In future, if something likw this is needed, then maybe a join that concatenates all printable ASCII characters would serve better (e.g., "".join(b for b in line if b >= 32)), instead of trying to cut out the nonprintable chars.
jcole-crowdstrike committedMar 8, 2024 Configuration menu - View commit details
-
Copy full SHA for 8b8c76a - Browse repository at this point
Copy the full SHA 8b8c76aView commit details
Commits on Mar 11, 2024
-
Merge pull request #1853 from jcole-crowdstrike/fix-branch-name-regex…
…-to-handle-nbsp Update regex pattern to handle unicode whitespaces.
Configuration menu - View commit details
-
Copy full SHA for d40e7d0 - Browse repository at this point
Copy the full SHA d40e7d0View commit details -
Start fixing venv test fixture pip toml bug
This is not yet a usable fix, because venv.create only supports upgrade_deps on Python 3.9 and higher.
Configuration menu - View commit details
-
Copy full SHA for dd8ee4f - Browse repository at this point
Copy the full SHA dd8ee4fView commit details -
Upgrade test fixture pip in venv without upgrade_deps
Because the upgrade_deps parameter to venv.create, as well as related functionality such as the EnvBuilder.upgrade_dependencies method that it uses, are only available starting in Python 3.9. This also puts the name of the VirtualEnvironment.__init__ parameter for setting up pip in the test fixture virtual environment back from need_pip to with_pip, which may be more intuitive.
Configuration menu - View commit details
-
Copy full SHA for a262a06 - Browse repository at this point
Copy the full SHA a262a06View commit details -
Merge pull request #1864 from EliahKagan/pip-toml
Use upgraded pip in test fixture virtual environment
Configuration menu - View commit details
-
Copy full SHA for 49cb48a - Browse repository at this point
Copy the full SHA 49cb48aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b7f159 - Browse repository at this point
Copy the full SHA 0b7f159View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa9298a - Browse repository at this point
Copy the full SHA aa9298aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f889c4 - Browse repository at this point
Copy the full SHA 5f889c4View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff a083e8115807ff0a9b08a81d53e56190003e5354...5f889c4137d1d4442ab3ceb8e45c3c03cafded1a