Skip to content

refactor: rewrite proxy <=> client internals #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2018

Conversation

machour
Copy link
Member

@machour machour commented Apr 12, 2018

Description

As mentioned in #770, this is the smallest subset of changes required for the Proxy<=>Client refactoring.

  • Client methods don't trigger the fetch() anymore, but instead hands out all call parameters to the Proxy
  • only list and get operations are supported
  • Got rid of the weird & confusing splitArgs() things.
  • Our actions sets now contain the action "name"

Tested all the screens migrated to the new API so far, every one of them still work without changing a single char.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 43.282% when pulling 911b561 on machour:refactor/proxy-client into 4b32a92 on gitpoint:master.

Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for breaking things down into smaller digestable chunks :)

This looks great ✅

@housseindjirdeh housseindjirdeh merged commit 8f8f229 into gitpoint:master Apr 15, 2018
@machour machour deleted the refactor/proxy-client branch April 15, 2018 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants