Fix terminal split view disposable leaked (microsoft#241597)

Fixes microsoft#241596

Author: jeanp413

src/vs/workbench/contrib/terminal/browser/terminalGroup.ts

@@ -52,8 +52,9 @@ class SplitPaneContainer extends Disposable {
 	}
 
 	private _createSplitView(): void {
-		this._splitView = new SplitView(this._container, { orientation: this.orientation });
 		this._splitViewDisposables.clear();
+		this._splitView = new SplitView(this._container, { orientation: this.orientation });
+		this._splitViewDisposables.add(this._splitView);
 		this._splitViewDisposables.add(this._splitView.onDidSashReset(() => this._splitView.distributeViewSizes()));
 	}
 
@@ -180,8 +181,6 @@ class SplitPaneContainer extends Disposable {
 		while (this._container.children.length > 0) {
 			this._container.children[0].remove();
 		}
-		this._splitViewDisposables.clear();
-		this._splitView.dispose();
 
 		// Create new split view with updated orientation
 		this._createSplitView();
@@ -323,6 +322,7 @@ export class TerminalGroup extends Disposable implements ITerminalGroup {
 	override dispose(): void {
 		this._terminalInstances = [];
 		this._onInstancesChanged.fire();
+		this._splitPaneContainer?.dispose();
 		super.dispose();
 	}
 

src/vs/workbench/contrib/terminal/browser/widgets/widgetManager.ts

@@ -23,6 +23,8 @@ export class TerminalWidgetManager implements IDisposable {
 			this._container.remove();
 			this._container = undefined;
 		}
+		this._attached.forEach(w => w.dispose());
+		this._attached.clear();
 	}
 
 	attachWidget(widget: ITerminalWidget): IDisposable | undefined {

src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts

@@ -6,7 +6,7 @@
 import type { Terminal } from '@xterm/xterm';
 import { Event } from '../../../../../base/common/event.js';
 import { KeyCode, KeyMod } from '../../../../../base/common/keyCodes.js';
-import { Disposable, DisposableStore, IDisposable, MutableDisposable } from '../../../../../base/common/lifecycle.js';
+import { Disposable, DisposableStore, MutableDisposable } from '../../../../../base/common/lifecycle.js';
 import { isWindows } from '../../../../../base/common/platform.js';
 import { Position } from '../../../../../editor/common/core/position.js';
 import { localize2 } from '../../../../../nls.js';
@@ -68,7 +68,7 @@ export class TerminalAccessibleViewContribution extends Disposable implements IT
 	private _bufferTracker: BufferContentTracker | undefined;
 	private _bufferProvider: TerminalAccessibleBufferProvider | undefined;
 	private _xterm: Pick<IXtermTerminal, 'shellIntegration' | 'getFont'> & { raw: Terminal } | undefined;
-	private readonly _onDidRunCommand: MutableDisposable<IDisposable> = new MutableDisposable();
+	private readonly _onDidRunCommand = this._register(new MutableDisposable());
 
 	constructor(
 		private readonly _ctx: ITerminalContributionContext,
@@ -144,11 +144,11 @@ export class TerminalAccessibleViewContribution extends Disposable implements IT
 		}
 
 		const capability = this._ctx.instance.capabilities.get(TerminalCapability.CommandDetection)!;
-		this._onDidRunCommand.value = this._register(capability.onCommandExecuted(() => {
+		this._onDidRunCommand.value = capability.onCommandExecuted(() => {
 			if (this._ctx.instance.hasFocus) {
 				this.show();
 			}
-		}));
+		});
 	}
 
 	private _isTerminalAccessibleViewOpen(): boolean {

src/vs/workbench/contrib/terminalContrib/developer/browser/terminal.developer.contribution.ts

@@ -227,7 +227,7 @@ class DevModeContribution extends Disposable implements ITerminalContribution {
 	}
 
 	private _xterm: IXtermTerminal & { raw: Terminal } | undefined;
-	private readonly _activeDevModeDisposables = new MutableDisposable();
+	private readonly _activeDevModeDisposables = this._register(new MutableDisposable());
 	private _currentColor = 0;
 
 	private _state: DevModeContributionState = DevModeContributionState.Off;