Skip to content

Commit 1233ac3

Browse files
kylos101roboquat
authored andcommitted
[test] Check for errors immediately
1 parent baeada9 commit 1233ac3

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

test/pkg/integration/apis.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -528,19 +528,25 @@ OuterLoop:
528528
var findErr error
529529
if v.Name == "DB_PASSWORD" {
530530
password, findErr = FindValueFromEnvVar(v, client, namespace)
531+
if findErr != nil {
532+
return nil, findErr
533+
}
531534
} else if v.Name == "DB_PORT" {
532535
var portStr string
533536
portStr, findErr = FindValueFromEnvVar(v, client, namespace)
537+
if findErr != nil {
538+
return nil, findErr
539+
}
534540
pPort, err := strconv.ParseUint(portStr, 10, 16)
535541
if err != nil {
536542
return nil, xerrors.Errorf("error parsing DB_PORT '%s' on pod %s!", v.Value, pod.Name)
537543
}
538544
port = int32(pPort)
539545
} else if v.Name == "DB_HOST" {
540546
host, findErr = FindValueFromEnvVar(v, client, namespace)
541-
}
542-
if findErr != nil {
543-
return nil, findErr
547+
if findErr != nil {
548+
return nil, findErr
549+
}
544550
}
545551
if password != "" && port != 0 && host != "" {
546552
break OuterLoop

0 commit comments

Comments
 (0)