Skip to content

Commit a51b68d

Browse files
committed
Closes #38, Closes #39
Now the version of the application is available on the settings menu
1 parent d02c2e6 commit a51b68d

File tree

5 files changed

+14
-3
lines changed

5 files changed

+14
-3
lines changed

app/frontend/global/notification.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class GPNotification {
6262
let closeBtn = document.createElement('button');
6363

6464
closeBtn.className = 'close-button';
65-
closeBtn.title = MSGS['Close'];
65+
closeBtn.title = MSGS.Close;
6666
closeBtn.innerHTML = '<span class="octicon octicon-x"></span>';
6767
closeBtn.onclick = function () {
6868
this.close();

app/frontend/modules/settings-page.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
{ code: 'en', description: 'English'},
2727
{ code: 'pt-BR', description: 'Portuguese (Brazil)'}
2828
];
29+
30+
this.appVersion = require('./package').version;
2931

3032
this.hideSettingsPage = function () {
3133
this.showSettingsPage = false;

app/frontend/view/content/settings-page.html

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,13 @@
140140
<li>{{ MSGS.SettingsPage["GitPie is an open source git client that have the goal to be the most simple and nice client for any project and for any people"] }}</li>
141141
</ul>
142142
</li>
143+
144+
<li>
145+
<div class="label">{{ MSGS.SettingsPage.Version }}</div>
146+
<ul>
147+
<li>{{ settingsCtrl.appVersion }}</li>
148+
</ul>
149+
</li>
143150

144151
<li>
145152
<div class="label">{{ MSGS.SettingsPage.License }}</div>

language/en.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,8 @@
145145
"Navigate between repositories top to bottom": "Navigate between repositories top to bottom",
146146
"Navigate between repositories bottom to top": "Navigate between repositories bottom to top",
147147
"Add focus on the \"Search repositories\" field": "Add focus on the \"Search repositories\" field",
148-
"Close modal windows and header menus": "Close modal windows and header menus"
148+
"Close modal windows and header menus": "Close modal windows and header menus",
149+
"Version": "Version"
149150
},
150151

151152
"Authentication required": "Authentication required",

language/pt-BR.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,8 @@
145145
"Navigate between repositories top to bottom": "Navega entre os repositórios de cima para baixo",
146146
"Navigate between repositories bottom to top": "Navega entre os repositórios de baixo para cima",
147147
"Add focus on the \"Search repositories\" field": "Adiciona foco no campo \"Procurar repositórios\"",
148-
"Close modal windows and header menus": "Fecha janelas modais e menus de cabeçalho"
148+
"Close modal windows and header menus": "Fecha janelas modais e menus de cabeçalho",
149+
"Version": "Versão"
149150
},
150151

151152
"Authentication required": "Autenticação requerida",

0 commit comments

Comments
 (0)