Detect binary file by NULL byte (#219)

* Detect binary file by NULL byte

* Add description where the binary check and values come from

---------

Co-authored-by: Patrick Beuks <code@beuks.net>

Author: Patrick-Beuks

src/Gitonomy/Git/Blob.php

@@ -19,6 +19,11 @@
  */
 class Blob
 {
+    /**
+     * @var int Size that git uses to look for NULL byte: https://git.kernel.org/pub/scm/git/git.git/tree/xdiff-interface.c?h=v2.44.0#n193
+     */
+    private const FIRST_FEW_BYTES = 8000;
+
     /**
      * @var Repository
      */
@@ -39,6 +44,11 @@ class Blob
      */
     protected $mimetype;
 
+    /**
+     * @var bool
+     */
+    protected $text;
+
     /**
      * @param Repository $repository Repository where the blob is located
      * @param string     $hash       Hash of the blob
@@ -89,6 +99,9 @@ public function getMimetype()
     /**
      * Determines if file is binary.
      *
+     * Uses the same check that git uses to determine if a file is binary or not
+     * https://git.kernel.org/pub/scm/git/git.git/tree/xdiff-interface.c?h=v2.44.0#n193
+     *
      * @return bool
      */
     public function isBinary()
@@ -99,10 +112,17 @@ public function isBinary()
     /**
      * Determines if file is text.
      *
+     * Uses the same check that git uses to determine if a file is binary or not
+     * https://git.kernel.org/pub/scm/git/git.git/tree/xdiff-interface.c?h=v2.44.0#n193
+     *
      * @return bool
      */
     public function isText()
     {
-        return (bool) preg_match('#^text/|^application/xml#', $this->getMimetype());
+        if (null === $this->text) {
+            $this->text = !str_contains(substr($this->getContent(), 0, self::FIRST_FEW_BYTES), chr(0));
+        }
+
+        return $this->text;
     }
 }

tests/Gitonomy/Git/Tests/BlobTest.php

@@ -23,6 +23,11 @@ public function getReadmeBlob($repository)
         return $repository->getCommit(self::LONGFILE_COMMIT)->getTree()->resolvePath('README.md');
     }
 
+    public function getImageBlob($repository)
+    {
+        return $repository->getCommit(self::LONGFILE_COMMIT)->getTree()->resolvePath('image.jpg');
+    }
+
     /**
      * @dataProvider provideFoobar
      */
@@ -67,16 +72,20 @@ public function testGetMimetype($repository)
      */
     public function testIsText($repository)
     {
-        $blob = $this->getReadmeBlob($repository);
-        $this->assertTrue($blob->isText());
+        $readmeBlob = $this->getReadmeBlob($repository);
+        $this->assertTrue($readmeBlob->isText());
+        $imageBlob = $this->getImageBlob($repository);
+        $this->assertFalse($imageBlob->isText());
     }
 
     /**
      * @dataProvider provideFoobar
      */
     public function testIsBinary($repository)
     {
-        $blob = $this->getReadmeBlob($repository);
-        $this->assertFalse($blob->isBinary());
+        $readmeBlob = $this->getReadmeBlob($repository);
+        $this->assertFalse($readmeBlob->isBinary());
+        $imageBlob = $this->getImageBlob($repository);
+        $this->assertTrue($imageBlob->isBinary());
     }
 }