Skip to content

Commit 9f0ec08

Browse files
committed
Move GOLANG_FIPS=1 back into tests:fips CI job
Enabling `GOLANG_FIPS=1` as part of the build process caused a build failure in https://gitlab.com/gitlab-org/omnibus-gitlab/-/jobs/11294885432: ``` panic: opensslcrypto: can't enable FIPS mode for OpenSSL 1.1.1f 31 Mar 2020: FIPS_mode_set openssl error(s): error:0F06D065:common libcrypto routines:FIPS_mode_set:fips mode not supported ../crypto/o_fips.c:22 goroutine 1 [running]: crypto/internal/backend.init.0() crypto/internal/backend/openssl.go:77 +0x254 make: *** [Makefile:116: bin/gitlab-shell] Error 2 ```
1 parent e01513b commit 9f0ec08

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

.gitlab-ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ tests:fips:
186186
- .test-job
187187
variables:
188188
FIPS_MODE: 1
189+
GOLANG_FIPS: 1
189190
script:
190191
- make test_fancy
191192

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ ifeq (${FIPS_MODE}, 1)
2828
# If the golang-fips compiler is built with CGO_ENABLED=0, this needs to be
2929
# explicitly switched on.
3030
export CGO_ENABLED=1
31-
export GOLANG_FIPS=1
3231

3332
# Go 1.19 now requires GOEXPERIMENT=boringcrypto for FIPS compilation.
3433
# See https://github.com/golang/go/issues/51940 for more details.

0 commit comments

Comments
 (0)