Fix broken URLs for old GitLab instances #4273
Open
+34
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2162
Description
Since #2022, anyone using an old installation of GitLab can no longer use the View on Remote feature; all URLs produce a 404 since gitlab changed the URL format, and GitLens only supports the new format as of #2022
This PR adds a new option to the
gitlens.remote
setting, calledversion
. For example:This field could be reused by other providers in the future, if they need version-specific logic.
For gitlab, if the version is too old, the URLs will not include the
/-/
infixChecklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses