Skip to content

Commit 47d72df

Browse files
author
tim
committed
Fix checkstyle errors
1 parent 7bd4f98 commit 47d72df

File tree

5 files changed

+17
-12
lines changed

5 files changed

+17
-12
lines changed

src/main/java/com/github/timm/cucumber/generate/CucumberITGeneratorByFeature.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ public class CucumberITGeneratorByFeature implements CucumberITGenerator {
5050

5151

5252
/**
53+
* Constructor.
5354
* @param config The configuration parameters passed to the Maven Mojo
5455
* @param overriddenParameters Parameters overridden from Cucumber options VM parameter (-Dcucumber.options)
5556
* @param classNamingScheme The naming scheme to use for the generated class files
@@ -167,18 +168,18 @@ private void setFeatureFileLocation(final File file) {
167168
featureFileLocation = normalizePathSeparator(file);
168169
}
169170

170-
171+
171172
private void setParsedFeature(final Feature feature) {
172173
parsedFeature = feature;
173174
}
174-
175-
private static String normalizePathSeparator(File file) {
175+
176+
private static String normalizePathSeparator(final File file) {
176177
return file.getPath().replace(File.separatorChar, '/');
177178
}
178179

179180
private void writeContentFromTemplate(final Writer writer) {
180181
// to escape java
181-
EventCartridge ec = new EventCartridge();
182+
final EventCartridge ec = new EventCartridge();
182183
ec.addEventHandler(new EscapeJavaReference());
183184

184185
final VelocityContext context = new VelocityContext();
@@ -202,7 +203,7 @@ private void writeContentFromTemplate(final Writer writer) {
202203
*/
203204
private List<String> createPluginStrings() {
204205
final List<String> formatList = new ArrayList<String>();
205-
for (Plugin plugin : overriddenParameters.getPlugins()) {
206+
for (final Plugin plugin : overriddenParameters.getPlugins()) {
206207
formatList.add(plugin.asPluginString(fileCounter));
207208
}
208209
return formatList;
@@ -211,7 +212,7 @@ private List<String> createPluginStrings() {
211212

212213
private static final class EscapeJavaReference implements ReferenceInsertionEventHandler {
213214

214-
public Object referenceInsert(String reference, Object value) {
215+
public Object referenceInsert(final String reference, final Object value) {
215216
if (value == null) {
216217
return null;
217218
} else {

src/main/java/com/github/timm/cucumber/generate/CucumberITGeneratorByScenario.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import gherkin.ast.Location;
1212
import gherkin.ast.Node;
1313
import gherkin.ast.ScenarioDefinition;
14-
1514
import org.apache.commons.io.FilenameUtils;
1615
import org.apache.commons.lang.StringUtils;
1716
import org.apache.commons.lang3.StringEscapeUtils;
@@ -52,6 +51,7 @@ public class CucumberITGeneratorByScenario implements CucumberITGenerator {
5251

5352

5453
/**
54+
* Constructor.
5555
* @param config The configuration parameters passed to the Maven Mojo
5656
* @param overriddenParameters Parameters overridden from Cucumber options VM parameter (-Dcucumber.options)
5757
* @param classNamingScheme The naming scheme to use for the generated class files
@@ -156,7 +156,7 @@ private void writeFile(final File outputDirectory) throws MojoExecutionException
156156
private void setFeatureFileLocation(final File file, final Location location) {
157157
featureFileLocation = normalizePathSeparator(file).concat(":" + location.getLine());
158158
}
159-
159+
160160
private void setParsedFeature(final Feature feature) {
161161
parsedFeature = feature;
162162
}
@@ -165,13 +165,13 @@ private void setParsedScenario(final ScenarioDefinition scenario) {
165165
parsedScenario = scenario;
166166
}
167167

168-
private static String normalizePathSeparator(File file) {
168+
private static String normalizePathSeparator(final File file) {
169169
return file.getPath().replace(File.separatorChar, '/');
170170
}
171171

172172
private void writeContentFromTemplate(final Writer writer) {
173173
// to escape java
174-
EventCartridge ec = new EventCartridge();
174+
final EventCartridge ec = new EventCartridge();
175175
ec.addEventHandler(new EscapeJavaReference());
176176

177177
final VelocityContext context = new VelocityContext();
@@ -196,7 +196,7 @@ private void writeContentFromTemplate(final Writer writer) {
196196
*/
197197
private List<String> createPluginStrings() {
198198
final List<String> formatList = new ArrayList<String>();
199-
for (Plugin plugin : overriddenParameters.getPlugins()) {
199+
for (final Plugin plugin : overriddenParameters.getPlugins()) {
200200
formatList.add(plugin.asPluginString(fileCounter));
201201
}
202202
return formatList;
@@ -205,7 +205,7 @@ private List<String> createPluginStrings() {
205205

206206
private static final class EscapeJavaReference implements ReferenceInsertionEventHandler {
207207

208-
public Object referenceInsert(String reference, Object value) {
208+
public Object referenceInsert(final String reference, final Object value) {
209209
if (value == null) {
210210
return null;
211211
} else {

src/main/java/com/github/timm/cucumber/generate/CucumberITGeneratorFactory.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ public class CucumberITGeneratorFactory {
1010
private final FileGeneratorConfig config;
1111

1212
/**
13+
* Constructor.
1314
* @param config generator config.
1415
* @param overriddenParameters cucumber options params
1516
* @param classNamingScheme the class naming scheme to use

src/main/java/com/github/timm/cucumber/generate/name/ClassNamingSchemeFactory.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ public class ClassNamingSchemeFactory {
2020
private final ClassNamingScheme featureFileNamingScheme;
2121

2222
/**
23+
* Constructor.
2324
* @param counter Counter for adding 1-up numbers to generated class names.
2425
*/
2526
public ClassNamingSchemeFactory(final Counter counter) {

src/main/java/com/github/timm/cucumber/generate/name/PatternNamingScheme.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ public class PatternNamingScheme implements ClassNamingScheme {
2626
private final ClassNamingScheme featureFileNamingScheme;
2727

2828
/**
29+
* Constructor.
2930
* @param pattern The pattern to use.
3031
* @param counter Counter to generate one up numbers
3132
* @param featureFileNamingScheme Naming scheme to use for '{f}' placeholder
@@ -40,6 +41,7 @@ public PatternNamingScheme(final String pattern, final Counter counter,
4041
}
4142

4243
/**
44+
* Generate a class name using the required pattern and feature file.
4345
* @param featureFileName The feature file to generate a class name for
4446
* @return A class name based on the required pattern.
4547
*/

0 commit comments

Comments
 (0)