Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Undo githubteacher #37

Merged
merged 13 commits into from
Aug 15, 2019
Merged

Undo githubteacher #37

merged 13 commits into from
Aug 15, 2019

Conversation

partyshah
Copy link

No description provided.

@github-learning-lab github-learning-lab bot temporarily deployed to production August 14, 2019 18:03 Inactive
@github-learning-lab
Copy link

Your draft course version was created!


You can edit it using the Course Builder UI!

@github-learning-lab github-learning-lab bot temporarily deployed to production August 14, 2019 18:06 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production August 14, 2019 20:53 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production August 14, 2019 20:59 Inactive
@partyshah
Copy link
Author

Alright, I fixed #38 , #40 , and #39 @hectorsector

@github-learning-lab github-learning-lab bot temporarily deployed to production August 14, 2019 22:55 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production August 14, 2019 23:16 Inactive
@partyshah
Copy link
Author

@hectorsector would you be able to take this course?

@hectorsector
Copy link
Member

@partyshah just did! Thanks for the improvements. There are still a number of missing validations, which I've opened issues for. Let's make sure those are taken care of. I'm merging this PR because it improves the experience, but the course isn't complete until we can validate the learner's steps.

@hectorsector hectorsector merged commit b7c7bd6 into master Aug 15, 2019
@hectorsector hectorsector deleted the partyshah-edits branch August 15, 2019 02:31
@partyshah partyshah mentioned this pull request Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants