Skip to content

Fix a few typos and a superfluous paragraph(?) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2020
Merged

Fix a few typos and a superfluous paragraph(?) #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11cffd7
Fix a few typos
asgerf May 6, 2020
4c691e5
Delete superfluous paragraph?
asgerf May 6, 2020
a10c2e4
Merge branch 'master' into asgerf/typos
adityasharad May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions javascript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ Each step has a **Solution** that indicates one possible answer. Note that all q

- Calling the predicate `jquery()` returns all values that refer to the `$` function.
- To find all calls to this function, use the predicate `getACall()`.
- Notice that when you call `jquery()`, `getACall()`, and `getAnArgument()` in succession, you get return values of type `DataFlow::Node`, not `Expr`. Thes are **data flow nodes**. They describe a part of the source program that may have a value, and let us do more complex reasoning about this value. We'll learn more about these in the next section.
- Notice that when you call `jquery()`, `getACall()`, and `getAnArgument()` in succession, you get return values of type `DataFlow::Node`, not `Expr`. These are **data flow nodes**. They describe a part of the source program that may have a value, and let us do more complex reasoning about this value. We'll learn more about these in the next section.
- You can convert the data flow node back into an `Expr` using the predicate `asExpr()`.
</details><details>
<summary>Solution</summary>
Expand Down Expand Up @@ -233,7 +233,7 @@ Consider creating a new query for these next few steps, or commenting out your e
```
</details>

1. Find the last parameters of the jQuery plugin functions that you identified in the previous step. These parameters are the plugin options.
1. Find the last parameter of the jQuery plugin functions that you identified in the previous step. These parameters are the plugin options.

<details>
<summary>Hint</summary>
Expand Down Expand Up @@ -279,7 +279,7 @@ class Config extends TaintTracking::Configuration {
source = /** TODO fill me in from Section 2 **/
)
}
override predicate isSink(Node sink) {
override predicate isSink(DataFlow::Node sink) {
exists(/** TODO fill me in **/ |
sink = /** TODO fill me in from Section 1 **/
)
Expand Down